Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8.ns.pvc.matchLabels gives 404 #90

Closed
nick opened this issue Mar 8, 2017 · 2 comments
Closed

k8.ns.pvc.matchLabels gives 404 #90

nick opened this issue Mar 8, 2017 · 2 comments

Comments

@nick
Copy link
Contributor

nick commented Mar 8, 2017

I used to be able to call the following:

k8.ns.pvc.matchLabels({ app: 'test' }).get((err, sRes) => {

but that now gives a 'resource not found' error. I now have to call the following instead:

k8.ns.pvc.get({ qs: { labelSelector: 'app=test' } }, (err, sRes) => {
silasbw pushed a commit that referenced this issue Mar 9, 2017
fix(matchLabels): call BaseObject constructor with correct arguments
d189b7a 
[1] changed BaseObject so that its properties were no longer a
superset of the `options` BaseObject construtor argument (specifically
removing the `name` property). That broke `.match()` and
`.matchLabels()` which depended on that property.

Fixes: #90

[1]:d083f93#diff-86b75ecfbd25aa771c8e9e0dff8eb00fL25
@silasbw silasbw mentioned this issue Mar 9, 2017
Merged
@silasbw
Copy link
Contributor

silasbw commented Mar 9, 2017

Ugh, sorry about that. #91 is a fix. We do have a test for this (https://github.com/godaddy/kubernetes-client/blob/master/test/api-group.test.js#L208), but it "just happens to still work" because of how we've implemented Pods (https://github.com/godaddy/kubernetes-client/blob/master/lib/pods.js#L42).

jcrugzz pushed a commit that referenced this issue Mar 9, 2017
@silasbw @jcrugzz
fix(matchLabels): call BaseObject constructor with correct arguments (#…
9e1f2d6 
…91)

[1] changed BaseObject so that its properties were no longer a
superset of the `options` BaseObject construtor argument (specifically
removing the `name` property). That broke `.match()` and
`.matchLabels()` which depended on that property.

Fixes: #90

[1]:d083f93#diff-86b75ecfbd25aa771c8e9e0dff8eb00fL25
silasbw pushed a commit that referenced this issue Mar 9, 2017
test(matchLabels): add test for bug reported in [1]
8a48e6e 
[1]:#90
silasbw pushed a commit that referenced this issue Mar 9, 2017
test(matchLabels): add test for bug reported in [1]
17210dd 
[1]:#90
silasbw added a commit that referenced this issue Mar 9, 2017
@silasbw
test(matchLabels): add test for bug reported in #90 (#92)
7c15c9e 
#90
@silasbw
Copy link
Contributor

silasbw commented Mar 9, 2017

@nick we published [email protected] with the fix. Thanks for the bug report.

kdamedhaar added a commit to kdamedhaar/k8-client that referenced this issue Dec 17, 2020
@kdamedhaar
test(matchLabels): add test for bug reported in #90 (#92)
3261cb6 
godaddy/kubernetes-client#90
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nick @silasbw