Add feature LIKE & NOT LIKE condition. #103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpango
force-pushed
the
feature-like-not-like-condition
branch
from
105ccf5
to
94701cb
Compare
taylorchu
reviewed
Sep 18, 2017
condition.go
Outdated
|
|
||
| func buildLikeCmp(d Dialect, buf Buffer, pred string, column string, value interface{}) error { | ||
| if value == nil { | ||
| return ErrColumnNotSpecified |
There was a problem hiding this comment.
ErrColumnNotSpecified is not for this.
taylorchu
reviewed
Sep 18, 2017
condition.go
Outdated
| } | ||
| fallthrough | ||
| default: | ||
| return ErrColumnNotSpecified |
There was a problem hiding this comment.
ErrColumnNotSpecified is not for this
taylorchu
reviewed
Sep 18, 2017
| case reflect.Ptr, reflect.Interface: // pointer or interface | ||
| // for pointers & interfaces check | ||
| return buildLikeCmp(d, buf, pred, column, v.Elem().Interface()) | ||
| case reflect.Slice: |
There was a problem hiding this comment.
It seems weird to me to support slice. Could you explain?
There was a problem hiding this comment.
It is an implementation that takes into consideration that byte slice or rune slice comes in
|
What's the status of this pr? |
|
will this be merged? it seems like a useful feature... |
kpango
force-pushed
the
feature-like-not-like-condition
branch
from
66668ec
to
b70ec46
Compare
kpango
force-pushed
the
feature-like-not-like-condition
branch
from
b70ec46
to
8f3da24
Compare
|
Wanted to check in here - will this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add LIKE & NOT LIKE feature to condition.go for fuzzy search using LIKE
LIKE syntax is below
NOT LIKE syntax is below
this is the same as #75 contents