Add feature LIKE & NOT LIKE condition. #75

kpango · 2017-01-07T02:09:29Z

Add LIKE & NOT LIKE feature to condition.go for fuzzy search using LIKE

LIKE syntax is below

SELECT * FROM `table` WHERE `a` LIKE "%value%";

val := `%value%`
dbr.Select("*").From("table").Where(dbr.Like("a",val))

NOT LIKE syntax is below

SELECT * FROM `table` WHERE `b` NOT LIKE "%value%";

val := `%ng_value%`
dbr.Select("*").From("table").Where(dbr.NotLike("b",val))

bgaifullin · 2017-01-18T14:50:46Z

README.md

@@ -245,6 +245,8 @@ One common reason to use this is to prevent string concatenation in a loop.
 * Gte
 * Lt
 * Lte
+* Lk


'Like' will be better than 'Lk'

bgaifullin · 2017-01-18T14:54:56Z

condition.go

+			return nil
+		}
+		v := reflect.ValueOf(value)
+		if v.Kind() == reflect.Slice {


it is not good to hide errors. need to return error or pass value as is.
I think array of runs is valid argument for like, but it has type slice.

bgaifullin · 2017-01-18T14:57:06Z

condition.go

+// Otherwise it will be translated to `LIKE`.
+func Lk(column string, value interface{}) Builder {
+	return BuildFunc(func(d Dialect, buf Buffer) error {
+		if value == nil {


IMO: it would be better avoid some logic here and pass arguments as is to underlayed level. if aguments is not valid, user will be notified about this via query builder error or via sql error.

bgaifullin · 2017-01-18T14:57:26Z

README.md

@@ -245,6 +245,8 @@ One common reason to use this is to prevent string concatenation in a loop.
 * Gte
 * Lt
 * Lte
+* Lk
+* Nlk


NotLike will be better.

bgaifullin · 2017-01-18T14:58:20Z

condition_test.go

+			cond:  Lk("col", nil),
+			query: "",
+			value: nil,
+		},


please add test with array of runs.

kpango · 2017-01-22T03:31:56Z

@bgaifullin Thanks for your feedback!
I fixed the point you pointed out, so please check it.

bgaifullin · 2017-01-23T10:00:49Z

condition.go

+			return fmt.Errorf("Column %s NOT LIKE nil is Not Supported", column)
+		}
+
+		v := reflect.ValueOf(value)


I think the common part of this 2 functions can be moved to separate function.
something like this:
func Like(column string, value interface{}) Builder { return BuildFunc(func(d Dialect, buf Buffer) error { return buildLikeCmp(d, buf, "NOT LIKE", column, value) }

bgaifullin · 2017-01-23T10:07:13Z

condition.go

+		case v.Kind() == reflect.TypeOf([]rune{}).Kind() && v.Len() != 0:
+			return buildCmp(d, buf, "NOT LIKE", column, string(value.([]rune)))
+
+		case v.Kind() == reflect.TypeOf([0]rune{}).Kind() && v.Len() != 0:


bgaifullin · 2017-01-23T10:07:16Z

condition.go

+
+		v := reflect.ValueOf(value)
+		switch {
+		case v.Kind() == reflect.TypeOf([]rune{}).Kind() && v.Len() != 0:


I think it is not needed to check that v.Len() != 0, becuase 'LIKE ""' is valid expression.

bgaifullin · 2017-01-23T12:03:16Z

condition.go

+
+	v := reflect.ValueOf(value)
+	switch {
+	case v.Kind() == reflect.TypeOf([]rune{}).Kind() && v.Len() != 0:


Please clarify why does condition 'v.Len() != 0' need here.
I think it is valid to use empty string in like operator.

Sorry, the empty int slice and the byte slice were caught on Detect of the Rune slice so I temporarily left it.
I will fix it with the next commit so please wait for a while.

bgaifullin · 2017-01-25T14:48:13Z

condition.go

+	case v.Type() == reflect.TypeOf([]rune{}):
+		return buildCmp(d, buf, pred, column, string(value.([]rune)))
+
+	case v.Kind() == reflect.TypeOf([0]rune{}).Kind():


I think it would be better to avoid type checkin here. Because there is a lot of cases where value can be converted to proper string value.
there is also implemented logic to handle different interfaces and properly convert them into valid database value. (method encodePlaceholder)
In any case if user pass not valid value to your method, it will see result as failed sql query.

If you want to strict check that passed value is valid, I think it would be better to rewrite this function like this:

v := reflect.ValueOf(value) switch v.Kind() { case reflect.String: // pass as is return buildCmp(d, buf, pred, column, value) case reflect.Ptr, reflect.Interface: return buildLikeCmp(d, buf, pred, column, v.Elem.Interface()) case reflect.Slice: switch v.Type().Elem().Kind() { case reflect.Uint8: // bytes // interpolator will handle this case return buildCmp(d, buf, pred, column, value) case reflect.Int32: // rune // need to convert into string // I am not sure that it is good idea to convert rune here // I think it would be better to ask user to convert into string return buildCmp(d, buf, pred, column, string(value([]rune))) } fallthrough default: return fmt.Errorf("Column %s %s Invalid Value, string expected", column, pred) } }

I missed encodePlaceholder, it's a good idea, thank you! I will correct it!

bgaifullin · 2017-01-26T08:44:10Z

condition_test.go

 		},
 		{
 			cond:  Lte("col", 1),
 			query: "`col` <= ?",
 			value: []interface{}{1},
+			isErr: false,
+		},
+		{


LGTM.
IMO: it would be great also add tests case for []byte

countcb · 2017-07-31T12:20:08Z

@kpango Thanks for this! Really useful for my current project.

tyler-smith

Great feature, great tests. Just a couple small issues.

tyler-smith · 2017-09-15T22:04:40Z

condition.go

+
+func buildLikeCmp(d Dialect, buf Buffer, pred string, column string, value interface{}) error {
+	if value == nil {
+		return fmt.Errorf("Column %s %s nil is Not Supported", column, pred)


Please use an exported error value.

@tyler-smith I’m sorry, but because there was a problem with my repository management, I issued a new PR and the same content PR. And I fixed the pointed out matter.

#103

tyler-smith · 2017-09-15T22:05:05Z

condition.go

+		}
+		fallthrough
+	default:
+		return fmt.Errorf("Column %s %s Invalid Value, string expected", column, pred)


Please use an exported error value.

tyler-smith · 2017-09-15T22:05:44Z

condition.go

+	}
+}
+
+// Lk is `LIKE`.


Please use the correct function name for golint.

tyler-smith · 2017-09-15T22:05:53Z

condition.go

+	})
+}
+
+// Nlk is `NOT LIKE`.


Please use the correct function name for golint.

kpango · 2017-09-15T23:32:27Z

#103

Add feature LIKE & NOT LIKE condition.

9cf824b

bgaifullin suggested changes Jan 18, 2017

View reviewed changes

fix like notlike condition method name & rune slice logic

74c2714

bgaifullin suggested changes Jan 23, 2017

View reviewed changes

separate function to buildLikeCmp

d62a681

bgaifullin reviewed Jan 23, 2017

View reviewed changes

fix rune array detection logic

f20e605

bgaifullin reviewed Jan 25, 2017

View reviewed changes

reflection logic changed

7d744fe

bgaifullin approved these changes Jan 26, 2017

View reviewed changes

tyler-smith suggested changes Sep 15, 2017

View reviewed changes

kpango mentioned this pull request Sep 15, 2017

Add feature LIKE & NOT LIKE condition. #103

Closed

kpango closed this Sep 15, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add feature LIKE & NOT LIKE condition. #75

Add feature LIKE & NOT LIKE condition. #75

kpango commented Jan 7, 2017 •

edited

Loading

bgaifullin Jan 18, 2017

bgaifullin Jan 18, 2017

bgaifullin Jan 18, 2017

bgaifullin Jan 18, 2017

bgaifullin Jan 18, 2017

kpango commented Jan 22, 2017

bgaifullin Jan 23, 2017

bgaifullin Jan 23, 2017

bgaifullin Jan 23, 2017

bgaifullin Jan 23, 2017

kpango Jan 23, 2017

bgaifullin Jan 25, 2017

kpango Jan 25, 2017

bgaifullin Jan 26, 2017

countcb commented Jul 31, 2017

tyler-smith left a comment

tyler-smith Sep 15, 2017

kpango Sep 15, 2017 •

edited

Loading

tyler-smith Sep 15, 2017

tyler-smith Sep 15, 2017

tyler-smith Sep 15, 2017

kpango commented Sep 15, 2017

Add feature LIKE & NOT LIKE condition. #75

Add feature LIKE & NOT LIKE condition. #75

Conversation

kpango commented Jan 7, 2017 • edited Loading

Add LIKE & NOT LIKE feature to condition.go for fuzzy search using LIKE

LIKE syntax is below

NOT LIKE syntax is below

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpango commented Jan 22, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

countcb commented Jul 31, 2017

tyler-smith left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpango Sep 15, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kpango commented Sep 15, 2017

kpango commented Jan 7, 2017 •

edited

Loading

kpango Sep 15, 2017 •

edited

Loading