Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate server url ends with /go #24

Closed
wants to merge 1 commit into from
Closed

Validate server url ends with /go #24

wants to merge 1 commit into from

Conversation

ibnc
Copy link
Contributor

@ibnc ibnc commented Mar 19, 2019

Addresses #21

@ibnc ibnc requested a review from marques-work March 19, 2019 22:14
@marques-work
Copy link
Collaborator

@ibnc Whoops, pushed a similar fix with a bunch of other stuff already. The only change I'd make is to use strings.HasSuffix() instead of a regexp (no need for extra complexity). Otherwise I would have merged this if I monitored my notifications better :(.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marques-work marques-work Awaiting requested review from marques-work

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibnc @marques-work