Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on bad server-url #21

Closed
kierarad opened this issue Mar 11, 2019 · 3 comments
Closed

Panic on bad server-url #21

kierarad opened this issue Mar 11, 2019 · 3 comments
Assignees
@ibnc

Comments

@kierarad
Copy link
Contributor

Omitting /go
@ibnc ibnc self-assigned this Mar 19, 2019
@ibnc ibnc mentioned this issue Mar 19, 2019
Closed
@marques-work
Copy link
Collaborator

Actually, I believe the panic I saw was not related to /go -- that was a coincidence. Omitting /go failed somewhat silently.

The panic was caused by a bug in crypto/x509 for darwin builds of golang after 1.11.5. See golang/go#30763

@marques-work
Copy link
Collaborator

Reverting to 1.11.5 solves this issue.

@marques-work
Copy link
Collaborator

marques-work commented Mar 20, 2019 •
edited
Loading

Additionally, we need to validate the server base url before issuing a request as the user may manually modify the settings.yaml, thereby circumventing the validations provided through the config command; this leads to silent failures. Validating before sending a request should provide this missing coverage.

See commit: e144a98

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ibnc ibnc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@marques-work @kierarad @ibnc