-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functional tests #72
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blintConfig from GoblintAnalysis
* Remove duplicated junit dependencies from pom * Fix surefire plugin error by adding junit dependency * Remove unused imports * Add ability to check for logging messages * Format code * Fix preAnalyseTest
…tures where not necessary
Analysis tests
This reverts commit b97883a.
…nding with status `Aborted` and `VerifyError`
Refactor: improve maintainability
Closed
2 tasks
karoliineh
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds functional tests for the following functionalities:
Bug fixes:
preAnalyze
process;GobPieValidatorAdapter
)`;explodeGroupWarnings
setting was not only applied for the data race warnings but also exploded the group warnings that communicate the statistics of dead code and accesses;Refactorings:
getter
method that is now moved to thepreAnalyse
method;GoblintConfWatcher
, that is passed to theGoblintAnalysis
constructor as an argument instead of initializinggoblintConfWatcher
field with a newFileWatcher
inside the constructor; The functionalities concerning refreshing the Goblint configuration were also moved to this class instead of being in theGoblintAnalysis
class that should be only responsible for the functionalities concerning the analysis itself;runCommand
,preAnalyse
andabortAnalysis
methods were moved from theGoblintAnalysis
class toGoblintServer
;Builder
forGobPieConfiguration
to ease testing;equals
methods for many of the classes for testing purposes;GoblintSocketMessageConsumer.java
andGoblintSocketMessageProducer.java
were moved fromsrc/main/java/api/json
tosrc/main/java/api/jsonrpc
, so that in thejson
package, there are only JSON handlers and adapters;MagpieBridge
functionalities were moved to a separate packagesrc/main/java/magpiebridge
Coverage: