Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: improve maintainability #11

Merged
merged 17 commits into from
May 11, 2024
Merged

Refactor: improve maintainability #11

merged 17 commits into from
May 11, 2024

Conversation

karoliineh
Copy link
Collaborator

@karoliineh karoliineh commented May 9, 2024

Tests refactoring:

  • Move method mockGoblintServerIsAlive that is used in several Test classes to a new TestHelper class 60b433e
  • Inline initializing gsonBuilder from a dedicated method to class field 60b433e
  • Generalize readGoblintMessagesResponseJson and readGoblintFunctionsResponseJson to one function 60b433e
  • Move duplicated code fragments to a BeforeEach method in GoblintAnalysisTest 60b433e

Source refactoring:

  • Convert GobPieConfiguration class to a record 4a66bc3 1bdbec7
  • Convert GoblintFunctionsResult class to a record bbe19ec
  • Convert GoblintAnalysisResult class to a record 90aaf5a
  • Remove unused imports from several files b5370d2
  • Remove unused getter getType from GobPieException 84e9f4f

Improvements in tests:

  • Improve abortAnalysis assertions 60b433e
  • Add tests for Goblint responding with statuses Aborted or VerifyError bbe19ec
  • Change a test to cover a use case where analysis is called with incrementalAnalysis set to false 9977cdf

@karoliineh karoliineh changed the title Refactor: remove unused methods and use records to improve maintainability Refactor: improve maintainability May 9, 2024
@AnetteTaivere AnetteTaivere merged commit fa38aeb into master May 11, 2024
4 checks passed
@karoliineh karoliineh deleted the increase-coverage branch June 26, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants