Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Goblint conf file #2

Closed
sim642 opened this issue Sep 21, 2021 · 0 comments · Fixed by #7
Closed

Use Goblint conf file #2

sim642 opened this issue Sep 21, 2021 · 0 comments · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@sim642
Copy link
Member

sim642 commented Sep 21, 2021

Currently all Goblint options are hard-coded:
https://github.com/goblint/MagpieBridge-Goblint/blob/5df41b6821e9b44d9f0f49dd6bd6c59e8b0eb456/src/main/java/GoblintAnalysis.java#L29

It would be better to use a Goblint .json conf file to allow tuning Goblint options without having to change the plugin itself.
The use of json-messages result should still be hard-coded instead of requiring everyone to duplicate that in their Goblint conf for anything to work.
Moreover, the plugin should not assume that the Goblint binary is in the current directory (./goblint) but rather just expect it to be in PATH (e.g. installed in the opam switch).

Therefore, a suitable command line could be something like:

goblint --conf goblint.json --set result json-messages -o output.json
@sim642 sim642 added the enhancement New feature or request label Sep 21, 2021
@karoliineh karoliineh linked a pull request Oct 2, 2021 that will close this issue
karoliineh added a commit that referenced this issue Oct 14, 2021
…le in the project. #2

Analysis is now triggered on a file when the file gets opened in the IDE (in additon to triggering the analysis when the file is saved). Extension works with incremental.json conf file configuration, closes #5 (incremental.json conf is now used in the DemoProject as well).
karoliineh pushed a commit that referenced this issue Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants