Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2369) add total withdrawal columns #2653

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

LuccaBitfly
Copy link
Collaborator

@LuccaBitfly LuccaBitfly commented Oct 30, 2023

Same as #2653 but without query optimizations

🤖 Generated by Copilot at 959551c

This pull request adds support for exporting and tracking the total number and amount of withdrawals by validators in the validator_stats table. It introduces a new command export-stats-totals to the misc tool, which allows selecting and exporting specific columns from the table. It also adds two new columns (withdrawals_total and withdrawals_amount_total) to the table and the corresponding fields and db tags to the ValidatorStatsTableDbRow struct. It includes a SQL migration file to add and drop the new columns.

@LuccaBitfly LuccaBitfly marked this pull request as ready for review October 30, 2023 09:08
Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@LuccaBitfly LuccaBitfly merged commit 120ccfe into master Nov 2, 2023
3 checks passed
@LuccaBitfly LuccaBitfly deleted the BIDS-2369/addTotalWithdrawalOnlyDB branch November 2, 2023 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants