Bids 2369/total withdrawals stats #2581
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuccaBitfly
force-pushed
the
BIDS-2369/totalWithdrawalsStats
branch
2 times, most recently
from
b7fd02a to
325f579
Compare
LuccaBitfly
force-pushed
the
BIDS-2369/totalWithdrawalsStats
branch
from
325f579 to
2a5ba87
Compare
LuccaBitfly
commented
Oct 2, 2023
| @@ -783,3 +787,117 @@ func exportHistoricPrices(dayStart uint64, dayEnd uint64) { | |||
|
|
|||
| logrus.Info("historic price update run completed") | |||
| } | |||
|
|
|||
| func exportStatsTotals(columns string, dayStart, dayEnd, concurrency uint64) { | |||
There was a problem hiding this comment.
Example Usage:
go run cmd/misc/main.go --config __gitignore/config.yml --command export-stats-totals --columns withdrawals_total,withdrawals_amount_total --day-start 10 --day-end 12
Eisei24
requested changes
Oct 3, 2023
Eisei24
reviewed
Oct 4, 2023
LuccaBitfly
force-pushed
the
BIDS-2369/totalWithdrawalsStats
branch
from
d7c2964 to
f339a4a
Compare
peterbitfly
approved these changes
Oct 16, 2023
|
Splitting this PR into two parts, see #2653 |
|
See #2668 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at 2711c31
This pull request adds support for tracking and exporting the cumulative totals of withdrawals for validators in the
validator_statstable. It introduces a newexport-stats-totalscommand to themisctool, which populates the new columnswithdrawals_totalandwithdrawals_amount_totalin the table. It also improves the performance and accuracy of theapiValidatorfunction and thedbpackage functions that query the withdrawals totals. It includes a new SQL migration file,temp_add_total_withdrawals_stats.sql, to add and remove the new columns. It updates theValidatorStatsTableDbRowtype in thetypespackage to match the new table schema.