Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

providers/scim: optimize sending all members within a group #9968

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

BeryJu
Copy link
Member

@BeryJu BeryJu commented Jun 4, 2024

Details

Whenever possible, send group members as a patch after creating/updating a group. This makes it basically the last resort to send all groups in a big chunk since that can be quite resource intensive for SCIM remotes


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

@BeryJu BeryJu requested a review from a team as a code owner June 4, 2024 09:29
Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for authentik-storybook canceled.

Name Link
🔨 Latest commit 1e39705
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66c73e047ffba500085b6a0c

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for authentik-docs canceled.

Name Link
🔨 Latest commit 1e39705
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66c73e044360dd00083b0682

Copy link

codecov bot commented Jun 4, 2024

Codecov Report

Attention: Patch coverage is 86.20690% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.69%. Comparing base (e428e4c) to head (1e39705).
Report is 2 commits behind head on main.

Files Patch % Lines
authentik/providers/scim/clients/groups.py 82.60% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9968      +/-   ##
==========================================
- Coverage   92.76%   92.69%   -0.08%     
==========================================
  Files         736      736              
  Lines       36360    36377      +17     
==========================================
- Hits        33730    33719      -11     
- Misses       2630     2658      +28     
Flag Coverage Δ
e2e 49.16% <20.68%> (-0.12%) ⬇️
integration 25.04% <0.00%> (-0.02%) ⬇️
unit 90.24% <86.20%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Jun 4, 2024

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-f0cbe59ddb030a025e1fa14a8b385bc87c674e6a
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-f0cbe59ddb030a025e1fa14a8b385bc87c674e6a-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-f0cbe59ddb030a025e1fa14a8b385bc87c674e6a

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-f0cbe59ddb030a025e1fa14a8b385bc87c674e6a-arm64

Afterwards, run the upgrade commands from the latest release notes.

@BeryJu BeryJu force-pushed the providers/scim/optimize-member-full-send branch from f0cbe59 to a47885b Compare August 15, 2024 15:50
@BeryJu BeryJu force-pushed the providers/scim/optimize-member-full-send branch from a47885b to d5a4665 Compare August 16, 2024 10:15
@BeryJu BeryJu force-pushed the providers/scim/optimize-member-full-send branch from d5a4665 to 1e39705 Compare August 22, 2024 13:32
@BeryJu BeryJu merged commit eafb709 into main Aug 22, 2024
65 of 67 checks passed
@BeryJu BeryJu deleted the providers/scim/optimize-member-full-send branch August 22, 2024 14:39
kensternberg-authentik added a commit that referenced this pull request Aug 22, 2024
* main:
  website/docs: cve release notes (#11026)
  security: fix CVE-2024-42490 (#11022)
  web: bump API Client version (#11021)
  providers/scim: optimize sending all members within a group (#9968)
  providers/scim: add API endpoint to sync single user (#8486)
  web: bump chromedriver from 127.0.3 to 128.0.0 in /tests/wdio (#11017)
  web: dual-select uses, part 2: dual-select harder (#9377)
  web: fix flash of unstructured content, add tests for it (#11013)
  core: bump drf-orjson-renderer from 1.7.2 to 1.7.3 (#11015)
  core: bump github.com/gorilla/sessions from 1.3.0 to 1.4.0 (#11002)
  website/docs: Correct the forward authentication configuration template for Caddy (#11012)
kensternberg-authentik added a commit that referenced this pull request Aug 23, 2024
* main: (165 commits)
  web/flows: update flow background (#11044)
  web: bump API Client version (#11043)
  website/integrations: Correct Discord avatar code and add warning. (#11031)
  core, web: update translations (#11032)
  website: bump docusaurus-theme-openapi-docs from 4.0.0 to 4.0.1 in /website (#11034)
  core: bump ruff from 0.6.1 to 0.6.2 (#11035)
  core: bump goauthentik.io/api/v3 from 3.2024063.12 to 3.2024063.13 (#11036)
  web: bump the babel group across 1 directory with 3 updates (#11038)
  web: bump wireit from 0.14.7 to 0.14.8 in /web (#11039)
  web: bump @goauthentik/api from 2024.6.3-1723921843 to 2024.6.3-1724337552 in /web/sfe (#11040)
  enterprise: add up-to-date license status (#11042)
  website/docs: cve release notes (#11026)
  security: fix CVE-2024-42490 (#11022)
  web: bump API Client version (#11021)
  providers/scim: optimize sending all members within a group (#9968)
  providers/scim: add API endpoint to sync single user (#8486)
  web: bump chromedriver from 127.0.3 to 128.0.0 in /tests/wdio (#11017)
  web: dual-select uses, part 2: dual-select harder (#9377)
  web: fix flash of unstructured content, add tests for it (#11013)
  core: bump drf-orjson-renderer from 1.7.2 to 1.7.3 (#11015)
  ...
kensternberg-authentik added a commit that referenced this pull request Aug 26, 2024
* web/element/ak-select-table:
  Provide unit test accessibility to Firefox and Safari; wrap calls to manipulate test DOMs directly in a browser.exec call so they run in the proper context and be await()ed properly
  web: finalize testing for tables
  web: added basic unit testing to API-free tables
  website/docs: cve release notes (#11026)
  security: fix CVE-2024-42490 (#11022)
  web: bump API Client version (#11021)
  providers/scim: optimize sending all members within a group (#9968)
  providers/scim: add API endpoint to sync single user (#8486)
  web: bump chromedriver from 127.0.3 to 128.0.0 in /tests/wdio (#11017)
  web: dual-select uses, part 2: dual-select harder (#9377)
  web: fix flash of unstructured content, add tests for it (#11013)
  core: bump drf-orjson-renderer from 1.7.2 to 1.7.3 (#11015)
  core: bump github.com/gorilla/sessions from 1.3.0 to 1.4.0 (#11002)
  web: interim commit of the basic sortable & selectable table.
  website/docs: Correct the forward authentication configuration template for Caddy (#11012)
  web: test for flash of unstructured content
  web: comment on state management in API layer, move file to point to correct component under test.
  web: fix Flash of Unstructured Content while SearchSelect is loading from the backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant