Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website/integrations: Correct Discord avatar code and add warning. #11031

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

Aterfax
Copy link
Contributor

@Aterfax Aterfax commented Aug 22, 2024

Details

There's a mispelling which causes the avatar gathered to not be the desired size.

Additionally, larger avatars appear to cause "Header too large" errors when users attempt to access services (at least for me via a proxy provider.)

This can also be seen users have a very large JWT in their request headers. (You can use https://github.com/traefik/whoami for debugging).


Checklist

  • Local tests pass (ak test authentik/)
  • The code has been formatted (make lint-fix)

If an API change has been made

  • The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • The code has been formatted (make web)

If applicable

  • The documentation has been updated
  • The documentation has been formatted (make website)

There's a mispelling which causes the avatar gathered to not be the desired size.

Additionally, larger avatars appear to cause "Header too large" errors when users attempt to access services (at least for me via a proxy providers.)

This can also be seen users have a very large JWT in their request headers. (You can use https://github.com/traefik/whoami for debugging).

Signed-off-by: Aterfax <[email protected]>
@Aterfax Aterfax requested a review from a team as a code owner August 22, 2024 21:28
Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for authentik-storybook ready!

Name Link
🔨 Latest commit a9c5cbd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/66c7ad7f9346080008cc4362
😎 Deploy Preview https://deploy-preview-11031--authentik-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Aug 22, 2024

Deploy Preview for authentik-docs ready!

Name Link
🔨 Latest commit a9c5cbd
🔍 Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66c7ad7f7a55c50008d5e3cb
😎 Deploy Preview https://deploy-preview-11031--authentik-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.77%. Comparing base (b301048) to head (a9c5cbd).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11031      +/-   ##
==========================================
+ Coverage   92.76%   92.77%   +0.01%     
==========================================
  Files         736      736              
  Lines       36422    36422              
==========================================
+ Hits        33786    33791       +5     
+ Misses       2636     2631       -5     
Flag Coverage Δ
e2e 49.26% <ø> (ø)
integration 25.01% <ø> (ø)
unit 90.25% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BeryJu BeryJu changed the title Correct Discord avatar code and add warning. website/integrations: Correct Discord avatar code and add warning. Aug 23, 2024
@BeryJu BeryJu merged commit ff4ff15 into goauthentik:main Aug 23, 2024
67 of 68 checks passed
kensternberg-authentik added a commit that referenced this pull request Aug 23, 2024
* main: (165 commits)
  web/flows: update flow background (#11044)
  web: bump API Client version (#11043)
  website/integrations: Correct Discord avatar code and add warning. (#11031)
  core, web: update translations (#11032)
  website: bump docusaurus-theme-openapi-docs from 4.0.0 to 4.0.1 in /website (#11034)
  core: bump ruff from 0.6.1 to 0.6.2 (#11035)
  core: bump goauthentik.io/api/v3 from 3.2024063.12 to 3.2024063.13 (#11036)
  web: bump the babel group across 1 directory with 3 updates (#11038)
  web: bump wireit from 0.14.7 to 0.14.8 in /web (#11039)
  web: bump @goauthentik/api from 2024.6.3-1723921843 to 2024.6.3-1724337552 in /web/sfe (#11040)
  enterprise: add up-to-date license status (#11042)
  website/docs: cve release notes (#11026)
  security: fix CVE-2024-42490 (#11022)
  web: bump API Client version (#11021)
  providers/scim: optimize sending all members within a group (#9968)
  providers/scim: add API endpoint to sync single user (#8486)
  web: bump chromedriver from 127.0.3 to 128.0.0 in /tests/wdio (#11017)
  web: dual-select uses, part 2: dual-select harder (#9377)
  web: fix flash of unstructured content, add tests for it (#11013)
  core: bump drf-orjson-renderer from 1.7.2 to 1.7.3 (#11015)
  ...
kensternberg-authentik added a commit that referenced this pull request Aug 27, 2024
* dev:
  web/flows: update flow background (#11044)
  web: bump API Client version (#11043)
  website/integrations: Correct Discord avatar code and add warning. (#11031)
  core, web: update translations (#11032)
  website: bump docusaurus-theme-openapi-docs from 4.0.0 to 4.0.1 in /website (#11034)
  core: bump ruff from 0.6.1 to 0.6.2 (#11035)
  core: bump goauthentik.io/api/v3 from 3.2024063.12 to 3.2024063.13 (#11036)
  web: bump the babel group across 1 directory with 3 updates (#11038)
  web: bump wireit from 0.14.7 to 0.14.8 in /web (#11039)
  web: bump @goauthentik/api from 2024.6.3-1723921843 to 2024.6.3-1724337552 in /web/sfe (#11040)
  enterprise: add up-to-date license status (#11042)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants