Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PHP 8.0 support. #365

Merged
merged 5 commits into from
Jun 16, 2022
Merged

Added PHP 8.0 support. #365

merged 5 commits into from
Jun 16, 2022

Conversation

navneet0693
Copy link
Contributor

@navneet0693 navneet0693 commented Feb 8, 2022

  1. Update Drupal core version to 9.3.5 which supports PHP 8.0
  2. Updated travis configutation to install PHP 8.0
  3. Updated rector.php file to check againt PHP 8.0
  4. Changes from Upgrade to use Drupal 9.3 open_social_docker#19 are included for Docker image.
  5. Temporarily added: Updated docker installation steps to fetch latest docker versions. open_social_scripts#44 branch.

@navneet0693 navneet0693 changed the title Added PHP support. Added PHP 8.0 support. Feb 10, 2022
@navneet0693 navneet0693 marked this pull request as ready for review February 18, 2022 10:14
@navneet0693 navneet0693 force-pushed the issue/3260861-php8-support branch from b2e3890 to 12c7635 Compare February 25, 2022 07:42
@ronaldtebrake
Copy link
Collaborator

Seems like Travis isn't happy yet, any idea whats going on? Would be great to at least not see that error that seems related.

@navneet0693
Copy link
Contributor Author

@ronaldtebrake Travis is broken in general on this repository.

@navneet0693
Copy link
Contributor Author

New PR: goalgorilla/open_social#2919

1. Update Drupal core version to 9.3.5 which supports PHP 8.1
2. Updated travis configutation to install PHP 8.1
3. Updated rector.php file to check againt PHP 8.1
@navneet0693 navneet0693 force-pushed the issue/3260861-php8-support branch 6 times, most recently from addfb98 to fc752d5 Compare June 8, 2022 05:01
1. Used php 8.0.19 which is latest bug fix version of PHP available in travis.
2. Changed ci images to be temporarilty based on temporary D9 based images created for testing.
@navneet0693 navneet0693 force-pushed the issue/3260861-php8-support branch from 3bcfafa to 0e92471 Compare June 8, 2022 05:56
@navneet0693 navneet0693 merged commit 78be0ec into master Jun 16, 2022
@navneet0693 navneet0693 deleted the issue/3260861-php8-support branch June 16, 2022 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants