Issue #3260861 by tbsiqueira, navneet0693, apaderno: Add support for php 8.0

[tbsiqueira]

Problem

Add PHP 8 support to Open Social

Solution

Refactor code to support PHP 8 and maintain backward compatibility.

1. Updated php configurations from 7.4 to 8.0 in travis.yml, and github actions.
2. Temporarily changed drupal_social branch to 'dev-issue/3260861-php8-support'

Issue tracker

https://www.drupal.org/project/social/issues/3260861

Theme issue tracker

N/A

How to test

• All checks should pass.
• Open Social installation should be flawless on both PHP 7.4 and PHP 8.1 installations.
• Smoke test to see nothing break.

Definition of done

Before merge

• Code/peer review is completed
• All commit messages are clear and clean. If applicable a rebase was performed
• All automated tests are green
• Functional/manual tests of the acceptance criteria are approved
• All acceptance criteria were met
• If applicable (I.E. new hook_updates) the update path from previous versions (major and minor versions) are tested
• This pull request has all required labels (team/type/priority)
• This pull request has a milestone
• This pull request has an assignee (if applicable)
• Any front end changes are tested on all major browsers
• New UI elements, or changes on UI elements are approved by the design team
• New features, or feature changes are approved by the product owner

After merge

• Code is tested on all branches that it has been cherry-picked
• Update hook number might need adjustment, make sure they have the correct order
• The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N.A

Release notes

We are now supporting PHP 8.0

Change Record

N.A

Translations

N.A

[navneet0693]

@Kingdutch Please give this one a look. ^

[Kingdutch]

You pointed to OverviewTerms.php in Drupal core as an example of where they use depth so we can learn from them to make PHPStan happy.

// Depth should be added by Drupal core and is used in various places. 
// However it's also not officially documented, so in case Drupal core has not 
// made it available yet we load the depth ourselves and cache it on the term 
// entity.
if (!isset($term->depth)) {
  $parents = $this->entityTypeManager->getStorage('taxonomy_term')->loadParents((int) $term->id());
  $term->depth = count($parents);
}
// To make PHPStan happy we assert that `depth` is now indeed numeric since the types defined for magic `__get` actually return `FIeldItemListInterface` which is not the case for our special `depth` property.
assert(is_numeric($term->depth), "Expected TermInterface item to have a numeric depth but the value was of incorrect type or unset.");

$choice = new \stdClass();
$choice->option = [$term->id() => str_repeat('-', $term->depth) . $this->entityRepository->getTranslationFromContext($term)->label()];

[ronaldtebrake]

are these required? seems like they are not doing anything really

[tbsiqueira]

Closing this PR due to rebase issues replaces by #2976