Bugfix (v3): Marshal yaml 1.1 bool strings as explicit strings #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise tests of functions that do not exist in v2 fail
|
Well that's interesting I'll have to look into that |
|
Seems it was the CI import path |
laverya
changed the title
|
@niemeyer Could you please consider merging this PR? I'm currently using go-yaml v3 to unmarshal a YAML file, make some changes to a few structs and marshal it back into YAML. Due to this specific bug, |
|
this also fixes #214, which the issue I opened is a dupe of... |
|
Obsoleted by #583 . |
Ark-kun
reviewed
Apr 16, 2020
| return true | ||
| case "n", "N", "no", "No", "NO", "off", "Off", "OFF": | ||
| out.SetBool(false) | ||
| val, found := boolMap[resolved] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String values matching a boolean literal from the yaml 1.1 spec should be rendered with quotes to ensure backwards compatibility. This fixes #489.