Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis should use the v3 import path not v2 #485

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

laverya
Copy link
Contributor

@laverya laverya commented Jul 15, 2019

otherwise tests of functions that do not exist in v2 fail

EDIT:
Also, without this pr tests are run against the current v3 code, not the code in the pr
This largely invalidates the point of CI

otherwise tests of functions that do not exist in v2 fail
@laverya
Copy link
Contributor Author

laverya commented Jul 22, 2019

@niemeyer if the project is closed to PRs, just let me know
But leaving every pr here open without response is really depressing, especially things that should be approvable at a glance ☹️

@niemeyer
Copy link
Contributor

Every PR is open because you are only looking at open PRs.

I appreciate your help, and your patience.

@laverya
Copy link
Contributor Author

laverya commented Jul 22, 2019

It's been more than three months since your last comment on an open pr / merge of a pr / etc
That's what I was thinking of 😢

Thank you for the work you do on this project!

@laverya
Copy link
Contributor Author

laverya commented Jul 25, 2019

@niemeyer I think I should point out the importance of this PR

Without it, TravisCI uses the submitted code as gopkg.in/yaml.v2, which means that unit tests will fetch the v3 package from github to run against. This means you can't use the unit tests as evidence for a PR not breaking things...

(and for this reason I've merged this branch into most of my PRs - they all have tests that rely on updated behavior, and so would fail otherwise)

@niemeyer niemeyer merged commit 8274499 into go-yaml:v3 Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants