Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pagination for schedules #677

Merged
merged 4 commits into from
Jun 15, 2023
Merged

fix: pagination for schedules #677

merged 4 commits into from
Jun 15, 2023

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Jun 9, 2023

some missing pagination update calls from #660
clicking the older+newer was just refreshing the same content

@plyr4 plyr4 requested a review from a team as a code owner June 9, 2023 22:34
@plyr4
Copy link
Contributor Author

plyr4 commented Jun 9, 2023

side note, the whole loadRepoSubPage function needs a refactor. some pagination code and case toPage stuff could be consolidated

@plyr4 plyr4 self-assigned this Jun 9, 2023
@plyr4 plyr4 changed the title fix: update pagination for schedules fix pagination for schedules Jun 12, 2023
@plyr4 plyr4 changed the title fix pagination for schedules fix: pagination for schedules Jun 12, 2023
wass3rw3rk
wass3rw3rk previously approved these changes Jun 13, 2023
View reviewed changes
KellyMerrick
KellyMerrick approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit ed0251a into main Jun 15, 2023
@plyr4 plyr4 deleted the fix/schedules-pagination branch June 15, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wass3rw3rk wass3rw3rk wass3rw3rk approved these changes

@KellyMerrick KellyMerrick KellyMerrick approved these changes

Assignees

@plyr4 plyr4

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plyr4 @KellyMerrick @wass3rw3rk