-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(scheduled builds): Add UI for scheduled builds proposal #660
Conversation
is there a visual mock for what this is supposed to look like? |
I added some screenshots to the description |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome work, looks great so far.
just a couple tweaks, and a few comments/questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feedback inline; looks to be working fine. thanks for the work!
a couple of items:
docker compose addition
we should add VELA_SCHEDULE_ALLOWLIST: '*'
to the docker compose for the server here, just as we did in go-vela/server
design feedback for add/edit schedule
tl;dr: no edits requested at this time, although it would be neat if some of the following could make its way in prior to the release.
i'm not sure if there are additional plans for the add/edit view for a schedule, but it's a bit bare and geared towards advanced users at the moment. we can probably agree that cron is not the most approachable format for scheduling to start with, so i was really hoping that we can be a bit more helpful here. you will see that a few online editors stuff the raw cron expression under an "Advanced" section while the initial exposure is something more approachable (or there are helpful annotations or links to dedicated cron tools). here is some quick reference material:
- https://crontab.guru/
- https://tool.crontap.com/
- https://crontab.cronhub.io/
- https://github.com/Marak/cron-editor
- https://esarmientoe.github.io/cron-editor/
- https://karoletrych.github.io/vue-cron-editor/
(ignore the purple banner in the middle)
not saying any of these are perfect but there are some themes/ideas. i think it boils down to these points for the current implementation:
- what is "Entry"? What am I looking at? *
- either a link to an editor or more inline explanation what each field represents, etc *
- quick views to edit common daily, weekly, hourly, etc schedules in more human way
- a cron expression to word translator would be nice
- something that tells you when the current expression would run next (taking into account server time zone) *
- calendar view would be neat (but value-add is probably diminishing there?)
maybe we can add some of the items at minimum and let user feedback guide the rest. i put a *
next to the items that i view as lowest effort (honoring server timezone could be a little tricky?).
thoughts?
I changed entry to "Cron Expression" and added a help link to https://crontab.guru/ |
@JayCeeJr thanks for the edits.. agree - it should probably have a place in the docs as well but keeping it closer to the context (where it is being used) seems prudent. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing cypress tests still
thank you for the tweaks, looks good |
Empty
Add Form
List