Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Valuers by returning driver.ErrSkip if couldn't convert type internally #709

Merged
merged 1 commit into from
Nov 16, 2017
Merged

Fix Valuers by returning driver.ErrSkip if couldn't convert type internally #709

merged 1 commit into from
Nov 16, 2017

Commits on Nov 16, 2017

  1. Fix Valuers by returning driver.ErrSkip if couldn't convert type inte… 

    …rnally

Added a test that Valuer types are handled correctly. This test fails without the fix.

CheckNamedValue code was included recently and breaks existing applications:
go-sql-driver#690

Reported in:
go-sql-driver#708
    @randomjunk
    randomjunk committed Nov 16, 2017
    Configuration menu
    Copy the full SHA
    57372b7 View commit details
    Browse the repository at this point in the history