Fix Valuers by returning driver.ErrSkip if couldn't convert type internally #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnally Added a test that Valuer types are handled correctly. This test fails without the fix. CheckNamedValue code was included recently and breaks existing applications: go-sql-driver#690 Reported in: go-sql-driver#708
julienschmidt
approved these changes
Nov 16, 2017
|
Thanks for the quick fix! |
julienschmidt
pushed a commit
that referenced
this pull request
Nov 17, 2017
5 tasks
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this pull request
Mar 23, 2018
bLamarche413
pushed a commit
to bLamarche413/mysql
that referenced
this pull request
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CheckNamedValue was returning a hard error instead of driver.ErrSkip if it couldn't convert the type. This commit intercepts the error and returns driver.ErrSkip to fix the use of Valuers.
Added a test that Valuer types are handled correctly. This test fails without the fix.
CheckNamedValue code was included recently:
#690
Issue was reported in:
#708
Checklist