Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track the visited structures in the checkStruct function #19

Merged
merged 2 commits into from
Feb 11, 2023

Conversation

SVilgelm
Copy link
Contributor

fix #16 with stack overflow issue when a struct has the fields of self type

fix go-simpler#16 with stack overflow issue when a struct has the fields of self type
@codecov-commenter
Copy link

codecov-commenter commented Feb 11, 2023

Codecov Report

Merging #19 (6012aa1) into main (2ad105d) will increase coverage by 0.10%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #19      +/-   ##
==========================================
+ Coverage   95.34%   95.45%   +0.10%     
==========================================
  Files           1        1              
  Lines         129      132       +3     
==========================================
+ Hits          123      126       +3     
  Misses          4        4              
  Partials        2        2              
Impacted Files Coverage Δ
musttag.go 95.45% <100.00%> (+0.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tmzane tmzane changed the title track the visited structures in the checkStruct fucntion fix: track the visited structures in the checkStruct fucntion Feb 11, 2023
@tmzane tmzane self-requested a review February 11, 2023 23:22
@tmzane tmzane changed the title fix: track the visited structures in the checkStruct fucntion fix: track the visited structures in the checkStruct function Feb 11, 2023
Copy link
Member

@tmzane tmzane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you Sergey!

@tmzane tmzane merged commit 704834d into go-simpler:main Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stack overflow with v0.4.4
3 participants