Stack overflow with v0.4.4

[stoneman]

musttag 0.4.4 is experiencing a stack overflow when run on one of our projects. I can't share that project unfortunately but the output of musttag ./... is provided in the attached file.

The problem doesn't occur if I revert this change: 9229084#diff-cfb5a4e47e6f8c71c0c2f50fffec7a51b18984f95177a9c1af9c436475810a99R209-R213

I added some logging at it seems to be looping over some structs from go-github.

I'm out of time to look at this for now but thought I'd let you know what I've found so far in case the problem/solution is obvious to you.

[tmzane]

Thank you for the report, I'll take a look!

[AlekSi]

We are having the same issue in a public project that uses musttag via golangci-lint: https://github.com/FerretDB/FerretDB/actions/runs/4119737045/jobs/7113756954

[SVilgelm]

A simple package to reproduce:

package tmp

import (
	"encoding/json"
)

type Human struct {
	Mom      *Human   `json:"mom"`
	Dad      *Human   `json:"dad"`
	Children []*Human `json:"children"`
}

func encode(v *Human) ([]byte, error) {
	return json.Marshal(v)
}

so the stack overflow happens when a struct has a field with type of those struct, I already have a fix, will publish the PR in couple of minutes

[tmzane]

Hey @stoneman, I was going to release a new version when #17 is closed, so it would include all the recent fixes. But if you find the current state of main useful, I can definitely push a tag for it 👍

[tmzane]

Please take a look at https://github.com/junk1tm/musttag/releases/tag/v0.4.5