Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API should follow RequireSignInView (#8654) #8660

Closed
wants to merge 1 commit into from
Closed

API should follow RequireSignInView (#8654) #8660

wants to merge 1 commit into from

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 24, 2019

As title, backport from #8654

@lunny lunny added the type/bug label Oct 24, 2019
@lunny lunny added this to the 1.10.0 milestone Oct 24, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2019
@lafriks lafriks added the modifies/api This PR adds API routes or modifies them label Oct 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2019
@lunny
Copy link
Member Author

lunny commented Oct 24, 2019

This is not right.

@lunny lunny closed this Oct 24, 2019
@lunny lunny deleted the lunny/fix_api_login2 branch October 24, 2019 16:41
@lunny lunny removed this from the 1.10.0 milestone Oct 24, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @lafriks @zeripath @GiteaBot