Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API should follow RequireSignInView #8654

Merged
merged 2 commits into from
Oct 24, 2019
Merged

API should follow RequireSignInView #8654

merged 2 commits into from
Oct 24, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 24, 2019 •
edited
Loading

As title.

Currently when you set RequireSignInView on app.ini, you will be asked login on web UI but not on API visit.
This PR will fix this situation. All API routes will follow RequireSignInView setting.

@lunny lunny added this to the 1.11.0 milestone Oct 24, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ab791fe). Click here to learn what that means.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #8654   +/-   ##
=========================================
  Coverage          ?   41.66%           
=========================================
  Files             ?      530           
  Lines             ?    68597           
  Branches          ?        0           
=========================================
  Hits              ?    28583           
  Misses            ?    36355           
  Partials          ?     3659
Impacted Files Coverage Δ
routers/api/v1/api.go 72.83% <40%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab791fe...88a9f8d. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2019
@lunny
Copy link
Member Author

lunny commented Oct 24, 2019

make L-G-T-M work

@lunny lunny merged commit 3c63c3a into go-gitea:master Oct 24, 2019
@lunny lunny deleted the lunny/fix_api_login branch October 24, 2019 05:34
lunny added a commit to lunny/gitea that referenced this pull request Oct 24, 2019
@lunny
API should follow RequireSignInView (go-gitea#8654)
1cc00d1
lunny added a commit to lunny/gitea that referenced this pull request Oct 24, 2019
@lunny
API should follow RequireSignInView (go-gitea#8654)
4b040a4
@lunny lunny mentioned this pull request Oct 24, 2019
Closed
@lunny lunny added the backport/done All backports for this PR have been created label Oct 24, 2019
@lafriks lafriks added the modifies/api This PR adds API routes or modifies them label Oct 24, 2019
@lunny lunny mentioned this pull request Oct 24, 2019
Merged
lunny added a commit that referenced this pull request Oct 24, 2019
@lunny
API should follow RequireSignInView (#8654) (#8661)
ffff835
lunny added a commit that referenced this pull request Oct 24, 2019
@lunny
Revert "API should follow RequireSignInView (#8654) (#8661)"
c9dddbe 
This reverts commit ffff835.
lunny added a commit that referenced this pull request Oct 24, 2019
@lunny
Revert "API should follow RequireSignInView (#8654)"
3ee28d2 
This reverts commit 3c63c3a.
@lunny lunny mentioned this pull request Oct 24, 2019
Merged
@lunny lunny removed this from the 1.11.0 milestone Oct 24, 2019
zeripath pushed a commit that referenced this pull request Oct 24, 2019
@lunny @zeripath
Revert "API should follow RequireSignInView (#8654) (#8661)" (#8674)
1bcbc02 
This reverts commit ffff835.
zeripath pushed a commit that referenced this pull request Oct 24, 2019
@lunny @zeripath
Revert "API should follow RequireSignInView (#8654)" (#8675)
0a80164 
This reverts commit 3c63c3a.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guillep2k guillep2k guillep2k approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @guillep2k @jolheiser @lafriks @GiteaBot