Fix unclickable checkboxes (#30195) #30199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix go-gitea#30185, regression from go-gitea#30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that.
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lafriks
approved these changes
Mar 31, 2024
GiteaBot
added
lgtm/need 1
silverwind
approved these changes
Mar 31, 2024
GiteaBot
added
lgtm/done
silverwind
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #30195 by @silverwind
Fix #30185, regression from #30162.
The checkboxes were unclickable because the label was positioned over the checkbox with
padding. Now it usesmarginso the checkbox itself will be clickable in all cases.Secondly, I changed the for/id linking to also add missing
forattributes whenidis present. The other way around (onlyforpresent) is currently not handled and I think there are likey no occurences in the code and introducing new non-generatedids might cause problems elsewhere if we do, so I skipped on that.