Can't check "Dismiss stale approvals" nor "Ignore stale approvals" in repository branch settings #30185
Comments
lafriks
pushed a commit
that referenced
this issue
Mar 31, 2024
Fix #30185, regression from #30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that.
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Mar 31, 2024
Fix go-gitea#30185, regression from go-gitea#30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that.
silverwind
added a commit
that referenced
this issue
Mar 31, 2024
Backport #30195 by @silverwind Fix #30185, regression from #30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that. Co-authored-by: silverwind <[email protected]>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this issue
Apr 9, 2024
Fix go-gitea/gitea#30185, regression from go-gitea/gitea#30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that. (cherry picked from commit 640850e15f56bbe01f5d8ea407f99c79dc38457e)
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this issue
Apr 10, 2024
Backport #30195 by @silverwind Fix go-gitea/gitea#30185, regression from go-gitea/gitea#30162. The checkboxes were unclickable because the label was positioned over the checkbox with `padding`. Now it uses `margin` so the checkbox itself will be clickable in all cases. Secondly, I changed the for/id linking to also add missing `for` attributes when `id` is present. The other way around (only `for` present) is currently not handled and I think there are likey no occurences in the code and introducing new non-generated `id`s might cause problems elsewhere if we do, so I skipped on that. Co-authored-by: silverwind <[email protected]> (cherry picked from commit 9d38c4d60ef5bd015e1430386e38d9f32e050f8f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
Clicking these checkboxes does nothing.
Screenshots
.
Gitea Version
current main
Can you reproduce the bug on the Gitea demo site?
Yes
Operating System
No response
Browser Version
.
The text was updated successfully, but these errors were encountered: