-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hover background to wiki list page #27507
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a hover background for the wiki row in wiki list page, which make its behavior more close to repo's file list page. This patch also make the wiki-git-entry visible on the row is hovered instead of the cel, so users won't be confused since the 'grid' is not visible from the web page.
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Oct 7, 2023
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Oct 7, 2023
silverwind
approved these changes
Oct 7, 2023
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Oct 7, 2023
wxiaoguang
approved these changes
Oct 8, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Oct 8, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 8, 2023
@BLumia please fix the merge conflicts. 🍵 |
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Oct 8, 2023
delvh
added
backport/v1.21
This PR should be backported to Gitea 1.21
and removed
kind/ui
labels
Oct 8, 2023
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Oct 8, 2023
This patch adds a hover background for the wiki row in wiki list page, which make its behavior more close to repo's file list page. This patch also make the wiki-git-entry visible on the row is hovered instead of the cel, so users won't be confused since the 'grid' is not visible from the web page. After the patch: (when the wiki named 'Home' is hovered) ![image](https://github.com/go-gitea/gitea/assets/10095765/f6c67c41-ad54-4ce4-a3b1-8c7551396ce0)
zeripath
pushed a commit
that referenced
this pull request
Oct 8, 2023
Backport #27507 by @BLumia This patch adds a hover background for the wiki row in wiki list page, which make its behavior more close to repo's file list page. This patch also make the wiki-git-entry visible on the row is hovered instead of the cel, so users won't be confused since the 'grid' is not visible from the web page. After the patch: (when the wiki named 'Home' is hovered) ![image](https://github.com/go-gitea/gitea/assets/10095765/f6c67c41-ad54-4ce4-a3b1-8c7551396ce0) Co-authored-by: Gary Wang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 10, 2023
* giteaofficial/main: Respect SSH.KeygenPath option when calculating ssh key fingerprints (go-gitea#27536) Remove max-width and add hide text overflow (go-gitea#27359) Fix `environment-to-ini` inherited key bug (go-gitea#27543) Improve docs about register/run as a service (go-gitea#27461) api: GetPullRequestCommits: return file list (go-gitea#27483) switch to using official AWS step in release nightly (go-gitea#27532) Improve file history UI and fix URL escaping bug (go-gitea#27531) Improve dropdown's behavior when there is a search input in menu (go-gitea#27526) Simplify `contrib/backport` (go-gitea#27520) Add docs section for sub-paths with the container registry (go-gitea#27505) Document our new labeling strategy (go-gitea#27523) [skip ci] Updated translations via Crowdin Restore warning commit status (go-gitea#27504) Update labeler to match new labeling system (go-gitea#27525) Apply to become a maintainer (go-gitea#27522) Remove unnecessary desc for openssh key cron task (go-gitea#27515) Tweak labeler config (go-gitea#27502) Add hover background to wiki list page (go-gitea#27507) [FIX] missing ctx in new_form (go-gitea#27514)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
backport/v1.21
This PR should be backported to Gitea 1.21
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
topic/ui
Change the appearance of the Gitea UI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a hover background for the wiki row in wiki list page, which make its behavior more close to repo's file list page.
This patch also make the wiki-git-entry visible on the row is hovered instead of the cel, so users won't be confused since the 'grid' is not visible from the web page.
After the patch: (when the wiki named 'Home' is hovered)