Add docs section for sub-paths with the container registry #27505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KN4CK3R
added
type/docs
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
lunny
approved these changes
Oct 7, 2023
GiteaBot
added
lgtm/need 1
delvh
reviewed
Oct 7, 2023
wxiaoguang
reviewed
Oct 7, 2023
pull-request-size
bot
added
size/XS
delvh
approved these changes
Oct 8, 2023
GiteaBot
added
lgtm/done
silverwind
reviewed
Oct 8, 2023
|
|
||
| ## Docker / Container Registry | ||
|
|
||
| The container registry uses a fixed sub-path `/v2` which can't be changed. |
There was a problem hiding this comment.
Suggested change
| The container registry uses a fixed sub-path `/v2` which can't be changed. | |
| The docker container registry uses a fixed sub-path `/v2` which can't be changed. |
There was a problem hiding this comment.
Mentioning Docker just because that's the more common name. The correct form would be "OCI Registry" or such but then knowbody knows what's that section is about. On all other places we just use "Container Registry".
There was a problem hiding this comment.
The "docker" name is very ingrained in the community, but I could see renaming it to "OCI containers" may be more correct. Just "containers" may be ambigous as there are other types of containers as well, like LXC.
silverwind
reviewed
Oct 8, 2023
| @@ -381,3 +381,9 @@ If you really need to do so, to make Gitea works with sub-path (eg: `http://exam | |||
| 1. Set `[server] ROOT_URL = http://example.com/gitea/` in your `app.ini` file. | |||
| 2. Make the reverse-proxy pass `http://example.com/gitea/foo` to `http://gitea-server:3000/foo`. | |||
| 3. Make sure the reverse-proxy not decode the URI, the request `http://example.com/gitea/a%2Fb` should be passed as `http://gitea-server:3000/a%2Fb`. | |||
|
|
|||
| ## Docker / Container Registry | |||
There was a problem hiding this comment.
Suggested change
| ## Docker / Container Registry | |
| ## Docker container Registry |
There was a problem hiding this comment.
I think the original text means docker or other container registry like podman and etc. since the protocol is compatible.
There was a problem hiding this comment.
Docker / Container Registry is the right wording.
KN4CK3R
changed the title
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 10, 2023
* giteaofficial/main: Respect SSH.KeygenPath option when calculating ssh key fingerprints (go-gitea#27536) Remove max-width and add hide text overflow (go-gitea#27359) Fix `environment-to-ini` inherited key bug (go-gitea#27543) Improve docs about register/run as a service (go-gitea#27461) api: GetPullRequestCommits: return file list (go-gitea#27483) switch to using official AWS step in release nightly (go-gitea#27532) Improve file history UI and fix URL escaping bug (go-gitea#27531) Improve dropdown's behavior when there is a search input in menu (go-gitea#27526) Simplify `contrib/backport` (go-gitea#27520) Add docs section for sub-paths with the container registry (go-gitea#27505) Document our new labeling strategy (go-gitea#27523) [skip ci] Updated translations via Crowdin Restore warning commit status (go-gitea#27504) Update labeler to match new labeling system (go-gitea#27525) Apply to become a maintainer (go-gitea#27522) Remove unnecessary desc for openssh key cron task (go-gitea#27515) Tweak labeler config (go-gitea#27502) Add hover background to wiki list page (go-gitea#27507) [FIX] missing ctx in new_form (go-gitea#27514)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21092
suggested by #21092 (comment)