Add Index to action.user_id
#27403
Add Index to action.user_id
#27403
Conversation
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
GiteaBot
added
lgtm/need 1
| // Copyright 2023 The Gitea Authors. All rights reserved. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package v1_21 //nolint |
There was a problem hiding this comment.
Now we are in 1.22 dev cycle could you move this to the new package?
There was a problem hiding this comment.
Would that prevent a backport?
There was a problem hiding this comment.
I also think it would be better to backport it to 1.21 instead of treating it as a 1.22 feature.
There was a problem hiding this comment.
Since we have created v1.21 branch, we should not do that.
There was a problem hiding this comment.
This PR is made to be backported to 1.21, as it improves the performance and does not introduce new features
There was a problem hiding this comment.
We don't have any 1.22 migration yet, so I don't see the problem.
There was a problem hiding this comment.
@techknowlogick @lunny any objections/other ideas?
There was a problem hiding this comment.
I agree with @silverwind that we need to update how we do migrations, preferably tracking all migrations that are done instead of a counter (I'm a fan of how rails does their migrations). I wrote a library for exactly this for xorm, https://github.com/techknowlogick/xormigrate which is used by a few projects, and does allow for splitting things out into directories to ensure 100s of files aren't all in the same directory. This however is a larger conversation than just this PR.
Comment scoped to this PR: My personal preference would be to change it to 1.22 as that's the dev cycle we are in, and then backport it with the same 1.22 directory. However we are in the stage where migrations can still be backported, and 1.21 is not fully released yet, so I can see using 1.21 still.
There was a problem hiding this comment.
I think the directory should not represent the development circle. It should represent for which version the migration is.
There was a problem hiding this comment.
Ultimately it won't matter if the 1.21 has files in the 1.22 folder. so let's go with that.
GiteaBot
added
lgtm/blocked
GiteaBot
added
lgtm/done
denyskon
added
the
reviewed/wait-merge
Another Column that needs a Index. Found at https://codeberg.org/forgejo/discussions/issues/61#issuecomment-1258744. Co-authored-by: Giteabot <[email protected]>
GiteaBot
added
backport/done
Backport #27403 by @JakobDev Another Column that needs a Index. Found at https://codeberg.org/forgejo/discussions/issues/61#issuecomment-1258744. Co-authored-by: JakobDev <[email protected]>
* origin/main: When comparing with an non-exist repository, return 404 but 500 (go-gitea#27437) Fix pr template (go-gitea#27436) Use minimal required version on CI and remove unnecessary services (go-gitea#27429) Fix missing `ctx` in new_form.tmpl (go-gitea#27434) Use flex-container for repo and org settings (go-gitea#27418) Fix yet another `ctx` template bug (go-gitea#27417) Add Index to `action.user_id` (go-gitea#27403) [skip ci] Updated translations via Crowdin
|
This will be ignored because indexes have been defined in line 63 |
Another Column that needs a Index. Found at https://codeberg.org/forgejo/discussions/issues/61#issuecomment-1258744.