Skip to content

Commit

Permalink
Add Index to action.user_id (#27403)
Browse files Browse the repository at this point in the history
Another Column that needs a Index. Found at
https://codeberg.org/forgejo/discussions/issues/61#issuecomment-1258744.

Co-authored-by: Giteabot <[email protected]>
  • Loading branch information
JakobDev and GiteaBot authored Oct 4, 2023
1 parent b37f333 commit 4636f56
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 1 deletion.
2 changes: 1 addition & 1 deletion models/activities/action.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ func (at ActionType) InActions(actions ...string) bool {
// used in template render.
type Action struct {
ID int64 `xorm:"pk autoincr"`
UserID int64 // Receiver user id.
UserID int64 `xorm:"INDEX"` // Receiver user id.

This comment has been minimized.

Copy link
@lunny

lunny Mar 30, 2024

Member

This is will be ignored because indexes have been defined in line 63 TableIndices.

OpType ActionType
ActUserID int64 // Action user id.
ActUser *user_model.User `xorm:"-"`
Expand Down
2 changes: 2 additions & 0 deletions models/migrations/migrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -538,6 +538,8 @@ var migrations = []Migration{
NewMigration("Add Index to issue_user.issue_id", v1_21.AddIndexToIssueUserIssueID),
// v278 -> v279
NewMigration("Add Index to comment.dependent_issue_id", v1_21.AddIndexToCommentDependentIssueID),
// v279 -> v280
NewMigration("Add Index to action.user_id", v1_21.AddIndexToActionUserID),
}

// GetCurrentDBVersion returns the current db version
Expand Down
16 changes: 16 additions & 0 deletions models/migrations/v1_21/v279.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
// Copyright 2023 The Gitea Authors. All rights reserved.
// SPDX-License-Identifier: MIT

package v1_21 //nolint

import (
"xorm.io/xorm"
)

func AddIndexToActionUserID(x *xorm.Engine) error {
type Action struct {
UserID int64 `xorm:"INDEX"`
}

return x.Sync(new(Action))
}

0 comments on commit 4636f56

Please sign in to comment.