Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store and use seconds for timeline time comments #25392

Merged
merged 18 commits into from
Jun 23, 2023
Merged

Store and use seconds for timeline time comments #25392

merged 18 commits into from
Jun 23, 2023

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 20, 2023 •
edited
Loading

this will alow us to fully localize it later

PS: we can not migrate back as the old value was a one-way conversion

prepare for #25213

Sponsored by Kithara Software GmbH

@6543
store and use seconds for timeline time comments
4df03a3 
this will alow us to fully localize it later

PS: we can not migrate back as the old value was a one-way conversion
@6543 6543 added type/refactoring Existing code has been cleaned up. There should be no new functionality. outdated/theme/timetracker labels Jun 20, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 20, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 20, 2023
@6543 6543 marked this pull request as ready for review June 20, 2023 13:50
@6543 6543 added this to the 1.21.0 milestone Jun 20, 2023
@6543 6543 added the topic/accessibility This issue/pull request wants to improve the accessibility label Jun 20, 2023
@6543
Copy link
Member Author

6543 commented Jun 20, 2023

not sure if I should add the "accessibility" label right now as it's just a preparation ...

@6543 6543 mentioned this pull request Jun 20, 2023
Open
9 tasks
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2023
@6543 6543 removed the topic/accessibility This issue/pull request wants to improve the accessibility label Jun 22, 2023
@6543 6543 requested a review from wxiaoguang June 22, 2023 15:54
@6543 6543 requested a review from wxiaoguang June 23, 2023 11:44
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 23, 2023
@6543 6543 added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 23, 2023
@6543 6543 enabled auto-merge (squash) June 23, 2023 12:02
@6543 6543 merged commit b0215c4 into go-gitea:main Jun 23, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 23, 2023
@6543 6543 deleted the refactor_store_seconds-not-string branch June 23, 2023 15:23
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. outdated/theme/timetracker size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @silverwind @wxiaoguang @GiteaBot