-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add Sec2TrackedTime time format template helper #25213
base: main
Are you sure you want to change the base?
Conversation
As work-days/-weeks/-years ... differ from country and company, its not practicable to use it as time format
If something took 3 days, why should that differ from country and company? Do you want to use the displayed value for billing? |
@KN4CK3R yes |
I personally think that days only are counter-intuitive too. if you think a second time ... well but I'm happy to move it into a server config option through I think we can just separate time formation for tracked-time in any case Con: we can have large h values |
Then it's debatable if that's the common usecase. Other people want to say "this took me 3 days" without calculating the value. Similar to the "my child is 27 months old" people... well keep your secrets. |
well was it 3days non stop without sleep ;) |
well ... so should we go for a server config option? |
This is only about tracked time, right? I guess you could have a |
This comment was marked as outdated.
This comment was marked as outdated.
For i18n:
For template helper, if it really needs to add a function, it could be put into |
well I'll make backend just sends timestamps around ... and conversion can be done in frontend by mentioned browser apis ... |
I checked relative-time-element which has a |
To me, tracked time should always be displayed in hours as highest unit. The units days, weeks or even years works for something like "I started working on that 3 weeks ago." But if I say "It took me three days to finish this." It usually means, I got up, had a breakfast, worked some hours, had lunch, worked some hours, had dinner, went to bed and repeated that three times. In the current form here, 3 days means 72 hours. This is not what I expect. |
Highest displayed unit should be configurable and default to highest significant unit, I suppose. |
I'll make it a user setting ... and refactor the code bit by bit to get there :)
|
next pull towards 1. -> #25392 |
this will allow us to fully localize it later PS: we can not migrate back as the old value was a one-way conversion prepare for #25213 --- *Sponsored by Kithara Software GmbH*
Still WIP? |
yes ... Just look at the TODO that's a bigger one :) and I work on it via payed time so it's not as fast as stuff I do in my free time :D (because upstreaming has not the highest priority there) |
Hello, I believe that hour(minutes) are the most universal and cultural independent approach to understand amount of time spent for job to be done. That is why this is truly KISS approach. And not too much job to be done to implement this. |
I also agree that for time spent hours should be the highest measurement unit, days and others can be misunderstood and can be confusing |
yes I still want the underlaying code to be cleaner (before i remove the wip) :) |
Haha ok :) |
As work-days/-weeks/-years ... differ from country and company, its not practicable to use it as time format
TODOs:
Sponsored by Kithara Software GmbH