Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrectly quoted translation #24514

Merged
merged 5 commits into from
May 4, 2023
Merged

Fix incorrectly quoted translation #24514

merged 5 commits into from
May 4, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented May 4, 2023

Looks like crowdin cannot recognize a value start with double quote but not end with double quote.

图片

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 4, 2023
@delvh delvh changed the title Fix translation file crowdin compatible Fix incorrectly quoted translation May 4, 2023
@lunny
Copy link
Member Author

lunny commented May 4, 2023

@delvh I don't know if it's correct or not. ini package supports the format but crowdin doesn't.

@silverwind
Copy link
Member

Confirmed it's the only such case:

$ rg '= "' options/locale/locale_en-US.ini | grep -v '"$'
editor.file_is_a_symlink = "%s" is a symbolic link. Symbolic links cannot be edited in the web editor

@techknowlogick techknowlogick added this to the 1.20.0 milestone May 4, 2023
@techknowlogick techknowlogick merged commit 747e9f7 into go-gitea:main May 4, 2023
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 4, 2023
@lunny lunny deleted the lunny/fix_lang branch May 5, 2023 02:21
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 5, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
43987ed 
* upstream/main:
  Harmonize title formatting in `docs/content/doc/development/api-usage.en-us.md` (go-gitea#24529)
  automate locking closed threads (go-gitea#24525)
  [skip ci] Updated translations via Crowdin
  Display warning when user try to rename default branch (go-gitea#24512)
  Upgrade to Node 20 on CI, enable actions cancellation (go-gitea#24524)
  Fix incorrectly quoted translation (go-gitea#24514)
  Fix color for transfer related buttons when having no permission to act (go-gitea#24510)
  Fix some mistakes when using `ignSignIn` (go-gitea#24415)
  Remove unused zapx replace statement on go.mod (go-gitea#24515)
  Don't display creating page button in a mirror wiki repository (go-gitea#24395)
  Improve template system and panic recovery (go-gitea#24461)
  Faster git.GetDivergingCommits (go-gitea#24482)
  Merge setting.InitXXX into one function with options (go-gitea#24389)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @silverwind @wolfogre @delvh @techknowlogick @GiteaBot