-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster git.GetDivergingCommits #24482
Merged
techknowlogick
merged 5 commits into
go-gitea:main
from
oliverpool:faster_git_diverging_commits
May 4, 2023
Merged
Faster git.GetDivergingCommits #24482
techknowlogick
merged 5 commits into
go-gitea:main
from
oliverpool:faster_git_diverging_commits
May 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost 2x faster than calling git rev-list twice
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
May 2, 2023
pull-request-size
bot
added
the
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
label
May 2, 2023
silverwind
reviewed
May 3, 2023
6543
approved these changes
May 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice catch!
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
May 3, 2023
lunny
approved these changes
May 4, 2023
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
May 4, 2023
lunny
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 4, 2023
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
May 4, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
May 5, 2023
* upstream/main: Harmonize title formatting in `docs/content/doc/development/api-usage.en-us.md` (go-gitea#24529) automate locking closed threads (go-gitea#24525) [skip ci] Updated translations via Crowdin Display warning when user try to rename default branch (go-gitea#24512) Upgrade to Node 20 on CI, enable actions cancellation (go-gitea#24524) Fix incorrectly quoted translation (go-gitea#24514) Fix color for transfer related buttons when having no permission to act (go-gitea#24510) Fix some mistakes when using `ignSignIn` (go-gitea#24415) Remove unused zapx replace statement on go.mod (go-gitea#24515) Don't display creating page button in a mirror wiki repository (go-gitea#24395) Improve template system and panic recovery (go-gitea#24461) Faster git.GetDivergingCommits (go-gitea#24482) Merge setting.InitXXX into one function with options (go-gitea#24389)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
performance/speed
performance issues with slow downs
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
git rev-list --left-right
is almost 2x faster than callinggit rev-list
twice.On my machine:
At 086b226 (current state):
At 845fd83 (tip of this PR):
contributed in the context of @forgejo