Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration to fix external unit access mode of owner/admin team #24117

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Apr 14, 2023

Fix the incorrect migration in #23675 and #24012

External Unit (Tracker and Wiki) access mode should be read in owner/admin team.

@yp05327 yp05327 force-pushed the fix-enternal-unit-accessmode-in-owner-and-admin-team branch from 48c2e2c to 028ac24 Compare April 14, 2023 01:13
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 14, 2023
@lunny
Copy link
Member

lunny commented Apr 14, 2023

Maybe a doctor sub-command to check and fix is better than a migration. So that it could be backport to old version.

@yardenshoham yardenshoham added this to the 1.20.0 milestone Apr 14, 2023
@silverwind
Copy link
Member

Maybe a doctor sub-command to check and fix is better than a migration. So that it could be backport to old version.

I guess I do prefer automatic solutions, e.g. migrations.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #24117 (028ac24) into main (f521e88) will decrease coverage by 0.08%.
The diff coverage is 40.96%.

❗ Current head 028ac24 differs from pull request most recent head 8fe8241. Consider uploading reports for the commit 8fe8241 to get more accurate results

@@            Coverage Diff             @@
##             main   #24117      +/-   ##
==========================================
- Coverage   47.14%   47.06%   -0.08%     
==========================================
  Files        1149     1161      +12     
  Lines      151446   153785    +2339     
==========================================
+ Hits        71397    72379     +982     
- Misses      71611    72889    +1278     
- Partials     8438     8517      +79     
Impacted Files Coverage Δ
cmd/dump.go 0.64% <0.00%> (-0.03%) ⬇️
cmd/embedded.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
... and 60 more

... and 154 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@6543
Copy link
Member

6543 commented Apr 15, 2023

a doctor command could be used to backport ...

@6543 6543 enabled auto-merge (squash) April 15, 2023 13:27
@6543 6543 merged commit fa34951 into go-gitea:main Apr 15, 2023
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 18, 2023
* giteaofficial/main: (25 commits)
  zh-cn support on doc pages (go-gitea#24166)
  [skip ci] Updated translations via Crowdin
  Use double quotes consistently in en-US (go-gitea#24141)
  Use correct locale key for forks page (go-gitea#24172)
  Improve Wiki TOC (go-gitea#24137)
  Localize activity heatmap (except tooltip) (go-gitea#24131)
  Support triggering workflows by wiki related events (go-gitea#24119)
  add CLI command to register runner tokens (go-gitea#23762)
  Add new user types `reserved`, `bot`, and `remote` (go-gitea#24026)
  Fix Org edit page bugs: renaming detection, maxlength (go-gitea#24161)
  Make HAS_GO a simply expanded variable (go-gitea#24169)
  Support converting varchar to nvarchar for mssql database (go-gitea#24105)
  Fix math and mermaid rendering bugs (go-gitea#24049)
  Refactor locale number (go-gitea#24134)
  [skip ci] Updated translations via Crowdin
  Use 1.18's aria role for dropdown menus (go-gitea#24144)
  Set EasyMDE heading font-size to the same size as the resulting markdown (go-gitea#24151)
  Fix 2-dot direct compare to use the right base commit (go-gitea#24133)
  Add migration to fix external unit access mode of owner/admin team (go-gitea#24117)
  Remove untranslatable `on_date` key (go-gitea#24106)
  ...
silverwind added a commit that referenced this pull request Apr 19, 2023
Add test for #23675

Should be merged after #24117

---------

Co-authored-by: silverwind <[email protected]>
@yp05327 yp05327 deleted the fix-enternal-unit-accessmode-in-owner-and-admin-team branch April 20, 2023 02:46
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants