Add migration to fix external unit access mode of owner/admin team #24117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yp05327
force-pushed
the
fix-enternal-unit-accessmode-in-owner-and-admin-team
branch
from
48c2e2c
to
028ac24
Compare
lunny
approved these changes
Apr 14, 2023
GiteaBot
added
the
lgtm/need 1
|
Maybe a doctor sub-command to check and fix is better than a migration. So that it could be backport to old version. |
I guess I do prefer automatic solutions, e.g. migrations. |
6543
approved these changes
Apr 15, 2023
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #24117 +/- ##
==========================================
- Coverage 47.14% 47.06% -0.08%
==========================================
Files 1149 1161 +12
Lines 151446 153785 +2339
==========================================
+ Hits 71397 72379 +982
- Misses 71611 72889 +1278
- Partials 8438 8517 +79
... and 154 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
a doctor command could be used to backport ... |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 18, 2023
* giteaofficial/main: (25 commits) zh-cn support on doc pages (go-gitea#24166) [skip ci] Updated translations via Crowdin Use double quotes consistently in en-US (go-gitea#24141) Use correct locale key for forks page (go-gitea#24172) Improve Wiki TOC (go-gitea#24137) Localize activity heatmap (except tooltip) (go-gitea#24131) Support triggering workflows by wiki related events (go-gitea#24119) add CLI command to register runner tokens (go-gitea#23762) Add new user types `reserved`, `bot`, and `remote` (go-gitea#24026) Fix Org edit page bugs: renaming detection, maxlength (go-gitea#24161) Make HAS_GO a simply expanded variable (go-gitea#24169) Support converting varchar to nvarchar for mssql database (go-gitea#24105) Fix math and mermaid rendering bugs (go-gitea#24049) Refactor locale number (go-gitea#24134) [skip ci] Updated translations via Crowdin Use 1.18's aria role for dropdown menus (go-gitea#24144) Set EasyMDE heading font-size to the same size as the resulting markdown (go-gitea#24151) Fix 2-dot direct compare to use the right base commit (go-gitea#24133) Add migration to fix external unit access mode of owner/admin team (go-gitea#24117) Remove untranslatable `on_date` key (go-gitea#24106) ...
silverwind
added a commit
that referenced
this pull request
Apr 19, 2023
Add test for #23675 Should be merged after #24117 --------- Co-authored-by: silverwind <[email protected]>
yp05327
deleted the
fix-enternal-unit-accessmode-in-owner-and-admin-team
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the incorrect migration in #23675 and #24012
External Unit (Tracker and Wiki) access mode should be
readin owner/admin team.