Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix admin team access mode value in team_unit table #24012

Merged
merged 12 commits into from
Apr 13, 2023
Merged

Fix admin team access mode value in team_unit table #24012

merged 12 commits into from
Apr 13, 2023

Conversation

yp05327
Copy link
Contributor

@yp05327 yp05327 commented Apr 9, 2023

Same as #23675
Feedback: #23879 (comment)

@yp05327 yp05327 mentioned this pull request Apr 9, 2023
Merged
@codecov-commenter
Copy link

codecov-commenter commented Apr 9, 2023 •
edited
Loading

Codecov Report

Merging #24012 (7f6c03b) into main (f521e88) will decrease coverage by 0.08%.
The diff coverage is 39.71%.

@@            Coverage Diff             @@
##             main   #24012      +/-   ##
==========================================
- Coverage   47.14%   47.06%   -0.08%     
==========================================
  Files        1149     1161      +12     
  Lines      151446   153945    +2499     
==========================================
+ Hits        71397    72459    +1062     
- Misses      71611    72976    +1365     
- Partials     8438     8510      +72
Impacted Files Coverage Δ
cmd/dump.go 0.64% <0.00%> (-0.03%) ⬇️
cmd/embedded.go 0.00% <0.00%> (ø)
cmd/mailer.go 0.00% <0.00%> (ø)
cmd/manager.go 0.00% <0.00%> (ø)
cmd/manager_logging.go 0.00% <0.00%> (ø)
cmd/migrate_storage.go 5.76% <0.00%> (-0.12%) ⬇️
cmd/restore_repo.go 0.00% <0.00%> (ø)
cmd/web.go 0.00% <0.00%> (ø)
models/actions/run.go 1.63% <0.00%> (-0.10%) ⬇️
models/actions/runner.go 1.44% <ø> (ø)
... and 57 more

... and 147 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 9, 2023
@lunny lunny added type/bug outdated/backport/v1.19 This PR should be backported to Gitea 1.19 labels Apr 9, 2023
@lunny lunny added this to the 1.20.0 milestone Apr 9, 2023
@6543
Copy link
Member

6543 commented Apr 9, 2023

Well ... just to not get regressions again ... adding integration tests for that would be nice 😅

@yp05327 yp05327 mentioned this pull request Apr 13, 2023
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 13, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 13, 2023
@6543 6543 merged commit b7221be into go-gitea:main Apr 13, 2023
@GiteaBot
Copy link
Contributor

I was unable to create a backport for 1.19. @yp05327, please send one manually. 🍵

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Apr 13, 2023
@yp05327
Copy link
Contributor Author

yp05327 commented Apr 13, 2023

Oh no, forgot to mention in this PR. The migration is incorrect.
Planned to fix it today….

@yp05327 yp05327 mentioned this pull request Apr 14, 2023
Merged
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 14, 2023
@zjjhot
Merge remote-tracking branch 'upstream/main'
60fcb2f 
* upstream/main:
  Fix incorrect server error content in RunnersList (go-gitea#24118)
  [skip ci] Updated translations via Crowdin
  Improve git log for debugging (go-gitea#24095)
  Update redis library to support redis v7 (go-gitea#24114)
  Refactor cookie (go-gitea#24107)
  Fix admin team access mode value in team_unit table (go-gitea#24012)
  Add monospace toggle button to textarea (go-gitea#24034)
  Correct the access log format (go-gitea#24085)
  Changelog v1.19.1 (go-gitea#24079) (go-gitea#24092)
6543 pushed a commit that referenced this pull request Apr 15, 2023
@yp05327
Add migration to fix external unit access mode of owner/admin team (#…
fa34951 
…24117)

Fix the incorrect migration in #23675 and #24012

External Unit (Tracker and Wiki) access mode should be `read` in
owner/admin team.
@yp05327 yp05327 deleted the fix-team-permission-when-create-or-edit branch May 22, 2023 05:01
@yp05327 yp05327 mentioned this pull request Jul 4, 2023
Open
@lunny lunny removed the outdated/backport/v1.19 This PR should be backported to Gitea 1.19 label Jul 26, 2023
@GiteaBot
Copy link
Contributor

We lock pull requests 3 months after they were closed. If there's any need for further discussion, please open a new issue. 🍵

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@silverwind silverwind silverwind approved these changes

Assignees
No one assigned
Labels
backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.20.0
Development

Successfully merging this pull request may close these issues.
6 participants
@yp05327 @codecov-commenter @6543 @GiteaBot @silverwind @lunny