Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape provider name in oauth2 provider redirect #12648

Merged
merged 2 commits into from
Aug 30, 2020
Merged

Escape provider name in oauth2 provider redirect #12648

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941f0bc
Escape provider name in oauth2 provider redirect
zeripath Aug 30, 2020
c1a7157
Merge branch 'master' into fix-12647-escape-provider-name
lafriks Aug 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/auth/oauth2/oauth2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ package oauth2

import (
"net/http"
"net/url"

"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"
Expand Down Expand Up @@ -119,7 +120,7 @@ func RemoveProvider(providerName string) {

// used to create different types of goth providers
func createProvider(providerName, providerType, clientID, clientSecret, openIDConnectAutoDiscoveryURL string, customURLMapping *CustomURLMapping) (goth.Provider, error) {
callbackURL := setting.AppURL + "user/oauth2/" + providerName + "/callback"
callbackURL := setting.AppURL + "user/oauth2/" + url.PathEscape(providerName) + "/callback"

var provider goth.Provider
var err error
Expand Down