-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape provider name in oauth2 provider redirect #12648
Merged
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:fix-12647-escape-provider-name
Aug 30, 2020
Merged
Escape provider name in oauth2 provider redirect #12648
zeripath
merged 2 commits into
go-gitea:master
from
zeripath:fix-12647-escape-provider-name
Aug 30, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Aug 30, 2020
GiteaBot
added
the
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
label
Aug 30, 2020
will need a backport |
Codecov Report
@@ Coverage Diff @@
## master #12648 +/- ##
==========================================
- Coverage 43.33% 43.32% -0.01%
==========================================
Files 646 646
Lines 71588 71588
==========================================
- Hits 31020 31016 -4
- Misses 35558 35561 +3
- Partials 5010 5011 +1
Continue to review full report at Codecov.
|
mrsdizzie
approved these changes
Aug 30, 2020
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Aug 30, 2020
backport -> #12650 |
lafriks
approved these changes
Aug 30, 2020
🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
backport/done
All backports for this PR have been created
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
type/bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #12647
Signed-off-by: Andrew Thornton [email protected]