Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape provider name in oauth2 provider redirect #12648

Merged
merged 2 commits into from
Aug 30, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Aug 30, 2020

Fix #12647

Signed-off-by: Andrew Thornton [email protected]

@zeripath zeripath added this to the 1.13.0 milestone Aug 30, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 30, 2020
@6543
Copy link
Member

6543 commented Aug 30, 2020

will need a backport

@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2020

Codecov Report

Merging #12648 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12648      +/-   ##
==========================================
- Coverage   43.33%   43.32%   -0.01%     
==========================================
  Files         646      646              
  Lines       71588    71588              
==========================================
- Hits        31020    31016       -4     
- Misses      35558    35561       +3     
- Partials     5010     5011       +1     
Impacted Files Coverage Δ
modules/auth/oauth2/oauth2.go 27.58% <0.00%> (ø)
modules/util/timer.go 42.85% <0.00%> (-42.86%) ⬇️
modules/util/remove.go 65.38% <0.00%> (-15.39%) ⬇️
services/pull/update.go 51.92% <0.00%> (-5.77%) ⬇️
services/pull/temp_repo.go 26.59% <0.00%> (-3.20%) ⬇️
services/pull/check.go 47.69% <0.00%> (-2.31%) ⬇️
modules/log/event.go 57.54% <0.00%> (-1.89%) ⬇️
modules/log/file.go 73.60% <0.00%> (-1.61%) ⬇️
services/pull/pull.go 42.03% <0.00%> (-0.70%) ⬇️
models/error.go 34.81% <0.00%> (-0.52%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc69ff...c1a7157. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 30, 2020
@6543
Copy link
Member

6543 commented Aug 30, 2020

backport -> #12650

@lafriks
Copy link
Member

lafriks commented Aug 30, 2020

🚀

@lafriks lafriks added the backport/done All backports for this PR have been created label Aug 30, 2020
@zeripath zeripath merged commit 58f57b3 into go-gitea:master Aug 30, 2020
@zeripath zeripath deleted the fix-12647-escape-provider-name branch August 30, 2020 22:55
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Space in name of authentication source causes problems for Keycloak
6 participants