Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/proc: remove usage of gore dependency #3664

Merged
merged 4 commits into from
Feb 21, 2024

Conversation

derekparker
Copy link
Member

Implement the specific behavior we used from the gotetk/gore library without copying any code to avoid licensing issues.

Fixes #3661

@derekparker
Copy link
Member Author

Currently marking as draft, this PR still needs work but I wanted to push for awareness on the upcoming change.

Still to do:

  • Document offsets used when digging through moduledata
  • Support 32-bit
  • Support Darwin

@derekparker derekparker marked this pull request as ready for review February 20, 2024 21:43
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarzilli aarzilli merged commit 4a72c52 into go-delve:master Feb 21, 2024
2 checks passed
@aktau
Copy link

aktau commented Feb 21, 2024

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight (new) AGPL (Affero General Public License dependency go-delve/gore
3 participants