Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight (new) AGPL (Affero General Public License dependency go-delve/gore #3661

Closed
aktau opened this issue Feb 14, 2024 · 3 comments · Fixed by #3664
Closed

Highlight (new) AGPL (Affero General Public License dependency go-delve/gore #3661

aktau opened this issue Feb 14, 2024 · 3 comments · Fixed by #3664

Comments

@aktau
Copy link

aktau commented Feb 14, 2024

Since 2023-11-03 (6c77c35), Delve has an AGPL dependency in the form of:

  1. First pkg/internal/moduledata/moduledata.go (mostly taken from goretk/gore), the separate license is not highlighted here but can be inferred by the attribution to the source project.
  2. Later: Direct dependency on goretk/gore (6e8e1ce).
  3. Now: A fork of the dependency (go-delve/gore) (dda8f69)

The authors can (of course) use any compatible licensed library that they wish. But, the AGPL is often prohibited for use/import in larger companies due to the stringency of the requirements. This means that Delve won't be usable in those places (without patching at least). There may also be other users who'd like to know about the new restrictions.

My request isn't to stop using the library or anything like that (that's up to the authors), but to highlight the new AGPL nature of Delve more prominently somewhere. Thanks!

@derekparker
Copy link
Member

Hey,

Thank you for calling this out. The AGPL dependency was an unintended consequence of using that library, and we are working towards removing the dependency going forward.

@adonovan
Copy link

@prattmic points out that golang/go#58474 may be helpful to you.

@derekparker
Copy link
Member

@prattmic points out that golang/go#58474 may be helpful to you.

Thanks, yes I've been following that issue and golang/go#58474 (comment) would certainly be helpful going forward. The issue is maintaining current feature support in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants