feat: set MAX VM cycles from cli #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
📦 🌐 tendermint v2
ajnavarro
changed the title
ajnavarro
changed the title
moul
requested changes
May 19, 2023
There was a problem hiding this comment.
Hey @ajnavarro, I agree that we should make this editable. However, there are a few things to keep in mind:
- In the future, the value won't be dynamically determined by the node itself. Instead, it will be a variable derived from the genesis configuration. This variable can be updated through DAO votes in a new
r/system/variablesrealm (Creating ar/sys/configrealm for runtime configuration #1856). You can find more information about this in the following link: Include max memory size of GVM in genesis parameters? #761 (comment). - Our goal is to simplify the configuration process by introducing variables that can be set in both config files and the command-line interface (CLI). This will eliminate the need for concurrent implementation of configuration. For more details, please refer to this pull request: feat(cli): add listen flag #729 (review). Additionally, you can explore issue CLI refactor #731 for further information.
Here's my suggestion for the next steps:
- Wait for the completion of the merge for both feat: add support for toml configuration files + recursive flag definitions for subcommands #827 and fix(cli): accept flags after command's arguments #762 (which will likely happen today).
- Once those are merged, proceed by updating the commands package to automatically register flags for available configuration files. You can find more details in issue CLI refactor #731.
- Finally, add your new flag, but make sure to give it a name that reflects its purpose as the
GenesisMaxVMCyclerather than just theMAX_VM_CYCLE.
thehowl
reviewed
May 22, 2023
|
reading now |
jaekwon
reviewed
Jun 2, 2023
jaekwon
approved these changes
Jun 2, 2023
Before this change, some VM operations like loading a package or calling a public realm method had a hardcoded limit of 10M max allowed cycles. Whith this change that limit can be modified. Signed-off-by: Antonio Navarro <[email protected]>
Signed-off-by: Antonio Navarro Perez <[email protected]>
ajnavarro
force-pushed
the
feat/set-max-cpu-cycles
branch
from
b108d5f
to
4c85bdf
Compare
|
@moul addressed all your comments! |
moul
approved these changes
Jun 5, 2023
|
Thank you Antonio! |
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this change, some VM operations like loading a package or calling a public realm method had a hardcoded limit of 10M max allowed cycles. With this change that limit can be modified.
Usage:
gnoland --max-vm-cycles=0It closes #821
Contributors Checklist
BREAKING CHANGE: xxxmessage was included in the description