fix(cli): accept flags after command's arguments

[tbruyelle]

Addresses #731

Description

This change allows to pass flags after a command's argument. This regression was added with the latest cli refactor that introduced the peterbourgon/ff/v3/ffcli library for command and flag parsing.

This change doesn't remove or replace ffcli, but instead suggest the minimal change to support flags after command's arguments. For that ffcli is forked inside tm2/pkg/commands/ffcli, and patched to support this feature.

The first commit just forks ffcli, while the second contains the patch, so I suggest to focus the review on this one.

Tests

Before that change, it was not possible to execute this command, because the -remote flags was expected before the auth/accounts/g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5 query argument.

gnokey query auth/accounts/g1jg8mtutu9khhfwc4nxmuhcpftf0pajdhfvsqf5  -remote https://test3.gno.land:36657

Additional notes

I wanted to bring the minimal change, but maybe it's better to merge the forked ffcli and our legacy commands package to have a better code. Anyway this PR can be used as a preliminary work for a wider refactor.

[moul]

Looks nice, and the first step going in the direction of #731.

Please, fix the CI, and I'll give a round of review.

[tbruyelle]

@moul I fixed the linter, but it seems I'm facing the port already in use problem. Can you rerun the test, I don't have that permission.

2023-04-20T21:18:18.3740807Z panic: failed to listen on 0.0.0.0:47768: listen tcp 0.0.0.0:47768: bind: address already in use
2023-04-20T21:18:18.3741407Z 
2023-04-20T21:18:18.3741950Z goroutine 1 [running]:
2023-04-20T21:18:18.3742491Z github.com/gnolang/gno/tm2/pkg/bft/rpc/lib.setup()
2023-04-20T21:18:18.3742891Z 	/home/runner/work/gno/gno/tm2/pkg/bft/rpc/lib/rpc_test.go:126 +0x9e7
2023-04-20T21:18:18.3743315Z github.com/gnolang/gno/tm2/pkg/bft/rpc/lib.TestMain(0xffffffffffffffff?)
2023-04-20T21:18:18.3743716Z 	/home/runner/work/gno/gno/tm2/pkg/bft/rpc/lib/rpc_test.go:86 +0x1e
2023-04-20T21:18:18.3743981Z main.main()
2023-04-20T21:18:18.3744198Z 	_testmain.go:59 +0x1d3
2023-04-20T21:18:18.3764770Z FAIL	github.com/gnolang/gno/tm2/pkg/bft/rpc/lib	0.007s

[thehowl]

diff between this and ffcli source: https://www.diffchecker.com/dtnUgZU6/

[zivkovicmilos]

I believe all gno CLI users will breathe a sigh of relief after we merge this out 🙂

Thank you for adding these changes, and for being thorough in the PR description / comments 🙏

[moul]

@tbruyelle can you rebase and fix conflicts? then we can merge.

[thehowl]

love this, Parse logic is clear and made me convinced it worked correctly without even seeing the tests, great job on the refactor

[tbruyelle]

@tbruyelle can you rebase and fix conflicts? then we can merge.

Conflicts fixed.