Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vmkeeper.maxcycles #2993

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Conversation

moul
Copy link
Member

@moul moul commented Oct 21, 2024

Let's remove the vn.maxCycles variable from the VM keeper so that it relies solely on the built-in gas system.

maxCycles remains an option on gno.Machine for blockchainless and gasless experiences.

@moul moul self-assigned this Oct 21, 2024
@github-actions github-actions bot added the 📦 ⛰️ gno.land Issues or PRs gno.land package related label Oct 21, 2024
Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 64.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 63.13%. Comparing base (88a0c4e) to head (2519add).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
gno.land/pkg/sdk/vm/keeper.go 60.86% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2993      +/-   ##
==========================================
+ Coverage   63.11%   63.13%   +0.02%     
==========================================
  Files         563      563              
  Lines       79284    79274      -10     
==========================================
+ Hits        50041    50051      +10     
+ Misses      25871    25853      -18     
+ Partials     3372     3370       -2     
Flag Coverage Δ
contribs/gnodev 60.57% <100.00%> (-0.05%) ⬇️
contribs/gnofaucet 15.77% <ø> (+0.94%) ⬆️
gno.land 67.38% <61.70%> (+0.01%) ⬆️
gnovm 67.26% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.39% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: moul <[email protected]>
@moul moul mentioned this pull request Oct 21, 2024
16 tasks
Signed-off-by: moul <[email protected]>
@moul moul marked this pull request as ready for review October 21, 2024 21:35
@moul moul merged commit 1154172 into gnolang:master Oct 22, 2024
118 checks passed
@moul moul deleted the dev/moul/remove-max-cycles branch October 22, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related
Projects
Status: Done
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants