-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tm2): add sdk/params module #2920
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2920 +/- ##
==========================================
- Coverage 63.18% 63.02% -0.17%
==========================================
Files 561 565 +4
Lines 78636 81124 +2488
==========================================
+ Hits 49690 51125 +1435
- Misses 25569 26545 +976
- Partials 3377 3454 +77
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
e31c026
to
c177c69
Compare
df1da8c
to
2a5b678
Compare
4c04221
to
95ab0bd
Compare
Signed-off-by: moul <[email protected]>
95ab0bd
to
783a044
Compare
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
The change does not appear to be applied to my PR #2920, so I am opening a dedicated PR to make Codecov aware. Signed-off-by: moul <[email protected]>
Could you elaborate on why this decision ? Edit(@moul): udpated the OC |
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added 2 more change requests but approving beforehand
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
Signed-off-by: moul <[email protected]>
- [x] add `r/sys/params` - [x] add `genesis/genesis_params.toml` - [x] port some existing configurations - [x] open issue: add LRU lazy caching with instant invalidation using a transient store (#3023) Depends on #2920 Depends on #3003 (cherry-picked) Blocking #2911 --------- Signed-off-by: moul <[email protected]> Co-authored-by: Morgan <[email protected]>
gnoland
783a044std.GetConfig
from the contract part? -> No, it allows unsafe, complex, and implicit patterns. If you want to get a value from another contract, you can either import it or use a registry pattern. This approach preserves type safety and other GNOVM protections.SetConfig
(onlyr/sys
), or maybe set an expensive gas price?interface{}
from the setters and use specific types, including in the tm2 implementation (string, uint64, int64, bool, bytes).<type>
suffix addition, but ensure that the type is explicitly defined by the user; and remove the table.Related #1418
Related #1856