Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tm2): Enable coin benchmark tests after fixing panic error #2884

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

sunspirit99
Copy link
Contributor

Relate to #907

Make a few small fixes to get this test working

Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.55%. Comparing base (1a57e81) to head (2a3605c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2884      +/-   ##
==========================================
+ Coverage   63.37%   63.55%   +0.18%     
==========================================
  Files         561      561              
  Lines       79199    79310     +111     
==========================================
+ Hits        50189    50403     +214     
+ Misses      25625    25523     -102     
+ Partials     3385     3384       -1     
Flag Coverage Δ
contribs/gnodev 60.57% <ø> (ø)
contribs/gnofaucet 14.82% <ø> (-0.95%) ⬇️
gno.land 67.38% <ø> (ø)
gnovm 67.93% <ø> (ø)
misc/genstd 79.72% <ø> (ø)
tm2 62.34% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kouteki Kouteki added the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 3, 2024
@notJoon
Copy link
Member

notJoon commented Oct 18, 2024

Could you please provide more detailed context for this PR's changes? thank you

tm2/pkg/std/coin_benchmark_test.go Outdated Show resolved Hide resolved
@jefft0 jefft0 removed the review/triage-pending PRs opened by external contributors that are waiting for the 1st review label Oct 22, 2024
@jefft0
Copy link
Contributor

jefft0 commented Oct 22, 2024

Removed the review/triage-pending label because core dev thehowl approved this PR.

@thehowl thehowl merged commit e34a8f7 into gnolang:master Oct 23, 2024
118 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🌐 tendermint v2 Issues or PRs tm2 related
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants