Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BenchmarkCoinsAdditionIntersect panicking with the message invalid denom: COINZ_0 #907

Closed
ajnavarro opened this issue Jun 16, 2023 · 0 comments
Labels
🐞 bug Something isn't working hacktoberfest This might be a good issue for a hacktoberfest participant to handle. help wanted Want to contribute? We recommend these issues. 📦 🌐 tendermint v2 Issues or PRs tm2 related

Comments

@ajnavarro
Copy link
Contributor

BenchmarkCoinsAdditionIntersect panicking with the message invalid denom: COINZ_0

Description

If you execute benchmark BenchmarkCoinsAdditionIntersect it will panic.

Steps to reproduce

  • Run the benchmark

Logs

goarch: amd64
pkg: github.com/gnolang/gno/tm2/pkg/std
cpu: AMD Ryzen 5 5600X 6-Core Processor
BenchmarkCoinsAdditionIntersect
BenchmarkCoinsAdditionIntersect/sizes:_A_1,_B_1
panic: invalid denom: COINZ_0

goroutine 8 [running]:
github.com/gnolang/gno/tm2/pkg/std.NewCoin(...)
	/home/ajnavarro/workspace/active/gno/tm2/pkg/std/coin.go:29
github.com/gnolang/gno/tm2/pkg/std.BenchmarkCoinsAdditionIntersect.func1.1(0xc000190280)
	/home/ajnavarro/workspace/active/gno/tm2/pkg/std/coin_benchmark_test.go:19 +0x25c
testing.(*B).runN(0xc000190280, 0x1)
	/usr/local/go/src/testing/benchmark.go:193 +0x102
testing.(*B).run1.func1()
	/usr/local/go/src/testing/benchmark.go:233 +0x59
created by testing.(*B).run1
	/usr/local/go/src/testing/benchmark.go:226 +0x9c
exit status 2
FAIL	github.com/gnolang/gno/tm2/pkg/std	0.006s
@ajnavarro ajnavarro added 🐞 bug Something isn't working 📦 🌐 tendermint v2 Issues or PRs tm2 related labels Jun 16, 2023
@moul moul modified the milestone: 🚀 main.gno.land Sep 6, 2023
@zivkovicmilos zivkovicmilos added 🌟 must have 🌟 help wanted Want to contribute? We recommend these issues. and removed 🌟 must have 🌟 labels Sep 12, 2024
@wyhaines wyhaines added the hacktoberfest This might be a good issue for a hacktoberfest participant to handle. label Oct 1, 2024
@thehowl thehowl closed this as completed Oct 23, 2024
thehowl pushed a commit that referenced this issue Oct 23, 2024
Relate to #907

Make a few small fixes to get this test working
<!-- please provide a detailed description of the changes made in this
pull request. -->

<details><summary>Contributors' checklist...</summary>

- [ ] Added new tests, or not needed, or not feasible
- [ ] Provided an example (e.g. screenshot) to aid review or the PR is
self-explanatory
- [ ] Updated the official documentation or not needed
- [ ] No breaking changes were made, or a `BREAKING CHANGE: xxx` message
was included in the description
- [ ] Added references to related issues and PRs
- [ ] Provided any useful hints for running manual tests
- [ ] Added new benchmarks to [generated
graphs](https://gnoland.github.io/benchmarks), if any. More info
[here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md).
</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working hacktoberfest This might be a good issue for a hacktoberfest participant to handle. help wanted Want to contribute? We recommend these issues. 📦 🌐 tendermint v2 Issues or PRs tm2 related
Development

No branches or pull requests

6 participants