Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add disperse (v2) #2613

Merged
merged 58 commits into from
Aug 21, 2024
Merged

Conversation

agherasie
Copy link
Contributor

This PR adds a gno version of the disperse ethereum app to gno.land !
Another attempt was made in #1414 but we have decided to pick up from @leohhhn 's work with @lennyvong and made this PR, tested using txtar tests to avoid the situation described in #2595
There is also an older (but functional for the most part) version deployed in test4 with a linked webapp

image
Contributors' checklist...
  • Added new tests, or not needed, or not feasible
  • Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory
  • Updated the official documentation or not needed
  • No breaking changes were made, or a BREAKING CHANGE: xxx message was included in the description
  • Added references to related issues and PRs
  • Provided any useful hints for running manual tests
  • Added new benchmarks to generated graphs, if any. More info here.

@github-actions github-actions bot added 🧾 package/realm Tag used for new Realms or Packages. 📦 ⛰️ gno.land Issues or PRs gno.land package related labels Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.22%. Comparing base (04d5239) to head (eb1dc54).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2613      +/-   ##
==========================================
- Coverage   60.23%   60.22%   -0.01%     
==========================================
  Files         562      562              
  Lines       75091    75091              
==========================================
- Hits        45230    45223       -7     
- Misses      26481    26486       +5     
- Partials     3380     3382       +2     
Flag Coverage Δ
contribs/gnodev 60.58% <ø> (-0.82%) ⬇️
contribs/gnofaucet 14.46% <ø> (-0.86%) ⬇️
gno.land 64.76% <ø> (ø)
gnovm 64.33% <ø> (ø)
misc/genstd 80.54% <ø> (ø)
misc/logos 19.88% <ø> (ø)
tm2 62.03% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agherasie
Copy link
Contributor Author

LGTM. Thanks for continuing this!

Left some comments to be addressed before we can go ahead with the merge 💯

@leohhhn I've addressed all of your comments and sent the relevant commits in replies except a few ones which were split across several commits

@agherasie agherasie requested a review from leohhhn August 15, 2024 12:26
examples/gno.land/r/demo/disperse/disperse.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/disperse/disperse.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/disperse/disperse.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/disperse/disperse.gno Outdated Show resolved Hide resolved
examples/gno.land/r/demo/disperse/disperse.gno Outdated Show resolved Hide resolved
@leohhhn
Copy link
Contributor

leohhhn commented Aug 15, 2024

Hey @agherasie, I left some more comments that should be addressed, but the gist is there.

@agherasie agherasie requested a review from leohhhn August 21, 2024 07:30
@leohhhn leohhhn merged commit aae5d49 into gnolang:master Aug 21, 2024
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 ⛰️ gno.land Issues or PRs gno.land package related 🧾 package/realm Tag used for new Realms or Packages.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants