-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add disperse (v2) #2613
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
- Coverage 60.23% 60.22% -0.01%
==========================================
Files 562 562
Lines 75091 75091
==========================================
- Hits 45230 45223 -7
- Misses 26481 26486 +5
- Partials 3380 3382 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@leohhhn I've addressed all of your comments and sent the relevant commits in replies except a few ones which were split across several commits |
Hey @agherasie, I left some more comments that should be addressed, but the gist is there. |
This PR adds a gno version of the disperse ethereum app to gno.land !
Another attempt was made in #1414 but we have decided to pick up from @leohhhn 's work with @lennyvong and made this PR, tested using txtar tests to avoid the situation described in #2595
There is also an older (but functional for the most part) version deployed in test4 with a linked webapp
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description