-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[gno test]: default realm balance in tests #2595
Comments
cc @thehowl |
leohhhn
added a commit
that referenced
this issue
Aug 21, 2024
This PR adds a gno version of the [disperse ethereum app](https://disperse.app/) to gno.land ! Another attempt was made in #1414 but we have decided to pick up from @leohhhn 's work with @lennyvong and made this PR, tested using txtar tests to avoid the situation described in #2595 There is also an older (but functional for the most part) version [deployed in test4](https://test4.gno.land/r/g1w62226g8hykfmtuasvz80rdf0jl6phgxsphh5v/testing/disperse2?help) with a linked [webapp](https://gno-disperse.netlify.app/) <img width="649" alt="image" src="https://github.com/user-attachments/assets/ad26a1a9-0447-4333-858a-253441c457ba"> <details><summary>Contributors' checklist...</summary> - [X] Added new tests, or not needed, or not feasible - [X] Provided an example (e.g. screenshot) to aid review or the PR is self-explanatory - [X] Updated the official documentation or not needed - [X] No breaking changes were made, or a `BREAKING CHANGE: xxx` message was included in the description - [X] Added references to related issues and PRs - [X] Provided any useful hints for running manual tests - [ ] Added new benchmarks to [generated graphs](https://gnoland.github.io/benchmarks), if any. More info [here](https://github.com/gnolang/gno/blob/master/.benchmarks/README.md). </details> --------- Co-authored-by: leohhhn <[email protected]> Co-authored-by: Leon Hudak <[email protected]> Co-authored-by: lennyvongphouthone <[email protected]> Co-authored-by: Guilhem Fanton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
I tried to write tests for disperse but I ran into a problem concerning the realm's balance in the testing scope.
There is a set amount of balance for every realm only in testing scope, which makes it difficult to test some functions using
gno test
. @leohhhn suggested I use txtar tests instead which I did, but I'm not sure why the tests work this way, and if there is a way / plan to change this in the futureThere is a part of the code which checks the contract's balance to send back the leftover amount if it exists
In the
gno test
scope, this doesn't work because the realm already has an existing balanceThe text was updated successfully, but these errors were encountered: