feat: lint all files in folder before panicking

gnovm/cmd/gno/lint.go

@@ -17,6 +17,7 @@
 	"github.com/gnolang/gno/gnovm/tests"
 	"github.com/gnolang/gno/tm2/pkg/commands"
 	osm "github.com/gnolang/gno/tm2/pkg/os"
+	"go.uber.org/multierr"
 )
 
 type lintCfg struct {
@@ -174,12 +175,18 @@
 		case *gno.PreprocessError:
 			err := verr.Unwrap()
 			fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
-		case scanner.ErrorList:
-			for _, err := range verr {
-				fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
-			}
 		case error:
-			fmt.Fprint(stderr, issueFromError(pkgPath, verr).String()+"\n")
+			errors := multierr.Errors(verr)
+			for _, err := range errors {
+				errList, ok := err.(scanner.ErrorList)
+				if ok {
+					for _, errorInList := range errList {
+						fmt.Fprint(stderr, issueFromError(pkgPath, errorInList).String()+"\n")
+					}
+				} else {
+					fmt.Fprint(stderr, issueFromError(pkgPath, err).String()+"\n")
+				}
+			}
 		case string:
 			fmt.Fprint(stderr, issueFromError(pkgPath, errors.New(verr)).String()+"\n")
 		default:

gnovm/cmd/gno/lint_test.go

@@ -23,6 +23,10 @@ func TestLintApp(t *testing.T) {
 			args:                []string{"lint", "../../tests/integ/several-lint-errors/main.gno"},
 			stderrShouldContain: "../../tests/integ/several-lint-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-lint-errors/main.gno:6",
 			errShouldBe:         "exit code: 1",
+		}, {
+			args:                []string{"lint", "../../tests/integ/several-files-multiple-errors/main.gno"},
+			stderrShouldContain: "../../tests/integ/several-files-multiple-errors/file2.gno:3: expected 'IDENT', found '{' (code=2).\n../../tests/integ/several-files-multiple-errors/file2.gno:5: expected type, found '}' (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:6: expected '}', found 'EOF' (code=2).\n",
+			errShouldBe:         "exit code: 1",
 		}, {
 			args:                []string{"lint", "../../tests/integ/run_main/"},
 			stderrShouldContain: "./../../tests/integ/run_main: missing 'gno.mod' file (code=1).",

gnovm/cmd/gno/run_test.go

@@ -83,6 +83,11 @@ func TestRunApp(t *testing.T) {
 			args:                []string{"run", "-expr", "Context()", "../../tests/integ/context/context.gno"},
 			stdoutShouldContain: "Context worked",
 		},
+		{
+			args:                []string{"run", "../../tests/integ/several-files-multiple-errors/"},
+			stderrShouldContain: "../../tests/integ/several-files-multiple-errors/file2.gno:3: expected 'IDENT', found '{' (code=2).\n../../tests/integ/several-files-multiple-errors/file2.gno:5: expected type, found '}' (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:5: expected ';', found example (code=2).\n../../tests/integ/several-files-multiple-errors/main.gno:6: expected '}', found 'EOF' (code=2).",
+			errShouldBe:         "exit code: 1",
+		},
 		// TODO: a test file
 		// TODO: args
 		// TODO: nativeLibs VS stdlibs

gnovm/cmd/gno/test.go

@@ -577,6 +577,7 @@
 func parseMemPackageTests(memPkg *std.MemPackage) (tset, itset *gno.FileSet) {
 	tset = &gno.FileSet{}
 	itset = &gno.FileSet{}
+	var errs error
 	for _, mfile := range memPkg.Files {
 		if !strings.HasSuffix(mfile.Name, ".gno") {
 			continue // skip this file.
@@ -586,7 +587,8 @@
 		}
 		n, err := gno.ParseFile(mfile.Name, mfile.Body)
 		if err != nil {
-			panic(err)
+			errs = multierr.Append(errs, err)
+			continue
 		}
 		if n == nil {
 			panic("should not happen")
@@ -606,6 +608,9 @@
 				memPkg.Name, memPkg.Name, n.PkgName, mfile))
 		}
 	}
+	if errs != nil {
+		panic(errs)
+	}
 	return tset, itset
 }
 

gnovm/pkg/gnolang/nodes.go

@@ -14,6 +14,7 @@
 
 	"github.com/gnolang/gno/tm2/pkg/errors"
 	"github.com/gnolang/gno/tm2/pkg/std"
+	"go.uber.org/multierr"
 )
 
 // ----------------------------------------
@@ -1189,14 +1190,16 @@
 // or [ParseFile] returns an error, ParseMemPackage panics.
 func ParseMemPackage(memPkg *std.MemPackage) (fset *FileSet) {
 	fset = &FileSet{}
+	var errs error
 	for _, mfile := range memPkg.Files {
 		if !strings.HasSuffix(mfile.Name, ".gno") ||
 			endsWith(mfile.Name, []string{"_test.gno", "_filetest.gno"}) {
 			continue // skip spurious or test file.
 		}
 		n, err := ParseFile(mfile.Name, mfile.Body)
 		if err != nil {
-			panic(err)
+			errs = multierr.Append(errs, err)
+			continue
 		}
 		if memPkg.Name != string(n.PkgName) {
 			panic(fmt.Sprintf(
@@ -1206,6 +1209,9 @@
 		// add package file.
 		fset.AddFiles(n)
 	}
+	if errs != nil {
+		panic(errs)
+	}
 	return fset
 }
 

gnovm/tests/integ/several-files-multiple-errors/file2.gno

@@ -0,0 +1,5 @@
+package main
+
+type{
+
+}

gnovm/tests/integ/several-files-multiple-errors/gno.mod

@@ -0,0 +1 @@
+module gno.land/tests/severalerrors

gnovm/tests/integ/several-files-multiple-errors/main.gno

@@ -0,0 +1,6 @@
+package main
+
+func main() {
+	for {
+		_ example
+}