-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lint all files in folder before panicking #2202
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Villaquiranm
requested review from
jaekwon,
moul,
piux2,
deelawn,
thehowl and
harry-hov
as code owners
May 26, 2024 13:46
Villaquiranm
force-pushed
the
lint-multiple-files
branch
from
May 26, 2024 13:51
5f97b9f
to
21b3e02
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2202 +/- ##
==========================================
- Coverage 63.10% 62.58% -0.52%
==========================================
Files 564 564
Lines 79273 83717 +4444
==========================================
+ Hits 50023 52397 +2374
- Misses 25886 27824 +1938
- Partials 3364 3496 +132
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
moul
reviewed
May 26, 2024
moul
reviewed
May 26, 2024
Villaquiranm
force-pushed
the
lint-multiple-files
branch
3 times, most recently
from
May 30, 2024 20:48
955cb1a
to
6be80ff
Compare
Villaquiranm
force-pushed
the
lint-multiple-files
branch
from
June 10, 2024 13:06
6be80ff
to
5819472
Compare
Villaquiranm
force-pushed
the
lint-multiple-files
branch
from
October 17, 2024 18:45
ff7c960
to
fdc6e61
Compare
Villaquiranm
force-pushed
the
lint-multiple-files
branch
from
October 17, 2024 20:09
dd10e11
to
ef19eb2
Compare
thehowl
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request intents to follow up on #2011. As said on that Pull request, currently we show all lint errors on the first analyzed file.
If in a folder we have
a.gno
&b.gno
both with lint errors.gno lint | run | test
will only find the errors related to one of those files.This PR aims to show all the lint errors present on the current folder.
Changes:
for lint & test cmd:
catchRuntimeError
function. We did this change in order to be able to recursively call the funtion and handle the case of an []error type composed of scanner.ErrorList errors.Results
LINT (before):
LINT (after):
Contributors' checklist...
BREAKING CHANGE: xxx
message was included in the description